[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1826: delete ClassTypeParameterName check

[GitBox <gi...@apache.org>]

imbajin commented on code in PR #1826:
URL: https://github.com/apache/incubator-hugegraph/pull/1826#discussion_r852054559


##########
style/checkstyle.xml:
##########
@@ -46,10 +46,10 @@
         <module name="TypeName">
             <message key="name.invalidPattern" value="Type name ''{0}'' must match pattern ''{1}''."/>
         </module>
-        <module name="ClassTypeParameterName">
-            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
-            <message key="name.invalidPattern" value="Class type name ''{0}'' must match pattern ''{1}''."/>
-        </module>
+<!--        <module name="ClassTypeParameterName">-->
+<!--            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>-->
+<!--            <message key="name.invalidPattern" value="Class type name ''{0}'' must match pattern ''{1}''."/>-->
+<!--        </module>-->

Review Comment:
   could we consider use low limit check rather than disable all?
   
   like `Class<a>` / `Class<1>` is not allowed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org