You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Jim Brennan (Jira)" <ji...@apache.org> on 2021/03/22 19:03:00 UTC

[jira] [Comment Edited] (YARN-10697) Resources are displayed in bytes in UI for schedulers other than capacity

    [ https://issues.apache.org/jira/browse/YARN-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306489#comment-17306489 ] 

Jim Brennan edited comment on YARN-10697 at 3/22/21, 7:02 PM:
--------------------------------------------------------------

Thanks for the update [~BilwaST]!
(edited) patch 002 looks mostly good, but can you please rename getResources()?  There is already a public Resource.getResources(), and the two functions are completely different.
Maybe the private one should be called getFormattedString()?   The new public one could also be getFormattedString().




was (Author: jim_brennan):
Thanks for the update [~BilwaST]!  +1 patch 002 looks good to me.


> Resources are displayed in bytes in UI for schedulers other than capacity
> -------------------------------------------------------------------------
>
>                 Key: YARN-10697
>                 URL: https://issues.apache.org/jira/browse/YARN-10697
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bilwa S T
>            Assignee: Bilwa S T
>            Priority: Major
>         Attachments: YARN-10697.001.patch, YARN-10697.002.patch, image-2021-03-17-11-30-57-216.png
>
>
> Resources.newInstance expects MB as memory whereas in MetricsOverviewTable passes resources in bytes . Also we should display memory in GB for better readability for user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org