Re: Review Request 16203: OOZIE-1624 Exclusion pattern for sharelib.

[Mona Chitnis <mo...@yahoo.in>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16203/#review38683
-----------------------------------------------------------


now the JIRA description is consistent. thanks


http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/16203/#comment70968>

    typo in conditi'o'nal



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/16203/#comment70974>

    Instead of a list of patterns and a O(n^2) comparison between patterns and jars later, can the Pattern be built here in the form of regex combining all the patterns? [exclusion-a-*.jar|exclusion-b-*.jar]


- Mona Chitnis


On Dec. 12, 2013, 6:23 a.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16203/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 6:23 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1624
>     https://issues.apache.org/jira/browse/OOZIE-1624
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> OOZIE-1624 Exclusion pattern for sharelib.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1550348 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestShareLibService.java 1550348 
>   http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1550348 
> 
> Diff: https://reviews.apache.org/r/16203/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>