You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/30 16:52:11 UTC

[GitHub] [incubator-druid] leventov opened a new issue #8445: In DirectDruidClient, Future cancellation listener shouldn't run in HTTP library thread

leventov opened a new issue #8445: In DirectDruidClient, Future cancellation listener shouldn't run in HTTP library thread
URL: https://github.com/apache/incubator-druid/issues/8445
 
 
   This `Futures.addCallback()` call:
   
   https://github.com/apache/incubator-druid/blob/984958122b962ab019a590f4fd01792de81b75df/server/src/main/java/org/apache/druid/client/DirectDruidClient.java#L453-L500
   
   Uses `MoreExecutors.sameThreadExecutor()` by default, which leads to canceling query (with waiting for one second) in the HTTP client thread (in `org.apache.druid.java.util.http.client.HttpClient`). This is undesirable because `HttpClient` is an asynchronous client.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org