[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #89: Make read-path Evaluators honor case sensitivity flag. Expose flag in Spark Reader.

[GitBox <gi...@apache.org>]

xabriel commented on a change in pull request #89: Make read-path Evaluators honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r263637746
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/TableScan.java
 ##########
 @@ -66,6 +66,17 @@
    */
   TableScan project(Schema schema);
 
+  /**
+   * Create a new {@link TableScan} from this that, if data columns where selected
+   * via {@link #select(java.util.Collection)}, controls whether the match to the schema will be done
+   * with case sensitivity.
+   *
+   * MUST be called before {@link #select(java.util.Collection)}!
 
 Review comment:
   Right, that is a reasonable expectation. Will fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org