You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Peter Somogyi (JIRA)" <ji...@apache.org> on 2019/08/05 09:10:00 UTC
[jira] [Commented] (HBASE-22731) ReplicationSource and
HBaseInterClusterReplicationEndpoint log messages should include a target
Peer identifier
[ https://issues.apache.org/jira/browse/HBASE-22731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899926#comment-16899926 ]
Peter Somogyi commented on HBASE-22731:
---------------------------------------
v2: -1
Generally it is a good idea to drop isTraceEnabled() and isDebugEnabled() but since you pass a costly method call (logPeerId()) as a parameter for the logger it will be evaluated every time even if the log level is WARN. For these DEBUG and TRACE level messages it would be better to keep the if statements.
> ReplicationSource and HBaseInterClusterReplicationEndpoint log messages should include a target Peer identifier
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-22731
> URL: https://issues.apache.org/jira/browse/HBASE-22731
> Project: HBase
> Issue Type: Improvement
> Components: Replication
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Minor
> Attachments: HBASE-22731.master.001.patch, HBASE-22731.master.002.patch
>
>
> _ReplicationSource_ and _HBaseInterClusterReplicationEndpoint_ already include a good number of helpful DEBUG and TRACE log messages to help us troubleshooting typical replication problems, such as lags or mysteriously missing edits on target peer.
> However, for each configured peer, there will be an individual _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ pair running in parallel, in scenarios where we need to investigate issues within a source to an specific peer, we can't distinguish from which peer specific _ReplicationSource_/_HBaseInterClusterReplicationEndpoint._ For such cases it would be nice to have an identifier for specific peer the given _ReplicationSource_/_HBaseInterClusterReplicationEndpoint_ is related to.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)