You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Dave Schindler (JIRA)" <ji...@apache.org> on 2009/07/28 17:54:58 UTC

[jira] Created: (WW-3207) Struts 2 submit tag is missing an "alt" attribute for type="image"

Struts 2 submit tag is missing an "alt" attribute for type="image"
------------------------------------------------------------------

                 Key: WW-3207
                 URL: https://issues.apache.org/struts/browse/WW-3207
             Project: Struts 2
          Issue Type: Bug
          Components: Plugin - Tags
            Reporter: Dave Schindler
            Priority: Minor


Example:

<s:submit type="image" src="image"/>

renders as

<input alt="Submit" src="image" id="someForm_0" value="Submit" type="image">

The alt attribute should be customizable.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3207) Struts 2 submit tag is missing an "alt" attribute for type="image"

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46801#action_46801 ] 

Wes Wannemacher commented on WW-3207:
-------------------------------------

you can customize it... you have to specify a value for the 'label' attribute -> 

<s:submit type="image" src="image" label="Some Alt Text" />

I'm not necessarily in favor of adding another attribute, so I am going to close this issue. If you had a different solution in mind, reopen this issue and provide more details.

> Struts 2 submit tag is missing an "alt" attribute for type="image"
> ------------------------------------------------------------------
>
>                 Key: WW-3207
>                 URL: https://issues.apache.org/struts/browse/WW-3207
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tags
>            Reporter: Dave Schindler
>            Priority: Minor
>             Fix For: 2.1.8
>
>
> Example:
> <s:submit type="image" src="image"/>
> renders as
> <input alt="Submit" src="image" id="someForm_0" value="Submit" type="image">
> The alt attribute should be customizable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-3207) Struts 2 submit tag is missing an "alt" attribute for type="image"

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes Wannemacher updated WW-3207:
--------------------------------

    Fix Version/s: 2.1.8

should be able to squeeze this in as part of 2.1.8

> Struts 2 submit tag is missing an "alt" attribute for type="image"
> ------------------------------------------------------------------
>
>                 Key: WW-3207
>                 URL: https://issues.apache.org/struts/browse/WW-3207
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tags
>            Reporter: Dave Schindler
>            Priority: Minor
>             Fix For: 2.1.8
>
>
> Example:
> <s:submit type="image" src="image"/>
> renders as
> <input alt="Submit" src="image" id="someForm_0" value="Submit" type="image">
> The alt attribute should be customizable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WW-3207) Struts 2 submit tag is missing an "alt" attribute for type="image"

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes Wannemacher closed WW-3207.
-------------------------------

    Resolution: Not A Problem

closing

> Struts 2 submit tag is missing an "alt" attribute for type="image"
> ------------------------------------------------------------------
>
>                 Key: WW-3207
>                 URL: https://issues.apache.org/struts/browse/WW-3207
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tags
>            Reporter: Dave Schindler
>            Priority: Minor
>             Fix For: 2.1.8
>
>
> Example:
> <s:submit type="image" src="image"/>
> renders as
> <input alt="Submit" src="image" id="someForm_0" value="Submit" type="image">
> The alt attribute should be customizable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3207) Struts 2 submit tag is missing an "alt" attribute for type="image"

Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46806#action_46806 ] 

Wes Wannemacher commented on WW-3207:
-------------------------------------

>> Having the label attribute handle the alt attribute's job isn't the most obvious solution

yeah, it's not optimum, but after looking a little closer at this - 

http://struts.apache.org/2.x/docs/submit.html

You will probably understand the reason why I don't want to add another attribute. There might be a better solution, currently the FM template basically says - if the type is 'image' and a 'label' attribute is specified, use it as 'alt' 

Another approach would be to say if the type is 'image' and there is an 'alt' specified, use it, otherwise go through the previous tests... But, then again, I figured that just pointing out you could use label= would be good enough. 

> Struts 2 submit tag is missing an "alt" attribute for type="image"
> ------------------------------------------------------------------
>
>                 Key: WW-3207
>                 URL: https://issues.apache.org/struts/browse/WW-3207
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tags
>            Reporter: Dave Schindler
>            Priority: Minor
>             Fix For: 2.1.8
>
>
> Example:
> <s:submit type="image" src="image"/>
> renders as
> <input alt="Submit" src="image" id="someForm_0" value="Submit" type="image">
> The alt attribute should be customizable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3207) Struts 2 submit tag is missing an "alt" attribute for type="image"

Posted by "Dave Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46804#action_46804 ] 

Dave Schindler commented on WW-3207:
------------------------------------

Having the label attribute handle the alt attribute's job isn't the most obvious solution, but it's a workable solution. Thanks for pointing it out.

> Struts 2 submit tag is missing an "alt" attribute for type="image"
> ------------------------------------------------------------------
>
>                 Key: WW-3207
>                 URL: https://issues.apache.org/struts/browse/WW-3207
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tags
>            Reporter: Dave Schindler
>            Priority: Minor
>             Fix For: 2.1.8
>
>
> Example:
> <s:submit type="image" src="image"/>
> renders as
> <input alt="Submit" src="image" id="someForm_0" value="Submit" type="image">
> The alt attribute should be customizable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.