[GitHub] [cassandra] Claudenw commented on a diff in pull request #2258: CASSANDRA-18221: Add AccordConfig to track accord specific configs

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on code in PR #2258:
URL: https://github.com/apache/cassandra/pull/2258#discussion_r1156858145


##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -596,6 +596,7 @@ public MemtableOptions()
     public volatile boolean use_statements_enabled = true;
 
     public boolean accord_transactions_enabled = false;
+    public long accord_scheduler_delay_in_ms = 200L;

Review Comment:
   Shouldn't this be a DurationSpec rather than a long particularly if you expect very large values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org