You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2011/01/10 17:30:46 UTC
[jira] Resolved: (WICKET-3311) Delete unused IPageSerializer & co
from o.a.w.Page class
[ https://issues.apache.org/jira/browse/WICKET-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3311.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
Assignee: Igor Vaynberg
> Delete unused IPageSerializer & co from o.a.w.Page class
> --------------------------------------------------------
>
> Key: WICKET-3311
> URL: https://issues.apache.org/jira/browse/WICKET-3311
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Attila Király
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-M4
>
> Attachments: WICKET-3311.patch
>
>
> It seems the Page class holds remnants of some old (based on svn introcued in the first half of 2007) page serialization infrastructure that is no longer in use.
> - Definition of IPageSerializer interface. It is not implemented or referenced anywhere outside Page class.
> - public static final ThreadLocal<IPageSerializer> serializer: It is not used anywhere outside Page class and it is only read in Page class itself. It is a problematic code anyway because it can lead to nasty memory leaks if not cleaned properly.
> - protected writeReplace() and package protected readPageObject(): not overridden or invoked from anywhere.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.