You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/08/26 04:49:37 UTC
Review Request 25055: Added logging when master/slaves/frameworks
bind to loopback address.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25055/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Added logging when master/slaves/frameworks bind to loopback address.
Diffs
-----
src/master/master.cpp 18464baad0864ae890d91097035edf8c49b6f60c
src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
src/slave/slave.cpp 6253a5dcde543ff448ad2e710a74892620e3bb87
Diff: https://reviews.apache.org/r/25055/diff/
Testing
-------
tested locally.
Thanks,
Vinod Kone
Re: Review Request 25055: Added logging when master/slaves/frameworks
bind to loopback address.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 26, 2014, 4:58 p.m., Dominic Hamon wrote:
> > src/master/master.cpp, line 289
> > <https://reviews.apache.org/r/25055/diff/1/?file=668747#file668747line289>
> >
> > The loopback address is guaranteed to be 127.x.x.x (any will work, 0.0.1 is standard) on any IPv4 machine and ::1 on any IPv6 machine.
> >
> > You probably want to extend this test to cover all of the IPv4 possibilities.
i'll follow up with another review. this has already been committed.
> On Aug. 26, 2014, 4:58 p.m., Dominic Hamon wrote:
> > src/scheduler/scheduler.cpp, line 131
> > <https://reviews.apache.org/r/25055/diff/1/?file=668749#file668749line131>
> >
> > worth a net::isLoopback() method?
sg.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25055/#review51539
-----------------------------------------------------------
On Aug. 26, 2014, 2:49 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25055/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 2:49 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added logging when master/slaves/frameworks bind to loopback address.
>
>
> Diffs
> -----
>
> src/master/master.cpp 18464baad0864ae890d91097035edf8c49b6f60c
> src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
> src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
> src/slave/slave.cpp 6253a5dcde543ff448ad2e710a74892620e3bb87
>
> Diff: https://reviews.apache.org/r/25055/diff/
>
>
> Testing
> -------
>
> tested locally.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 25055: Added logging when master/slaves/frameworks
bind to loopback address.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25055/#review51539
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/25055/#comment89947>
The loopback address is guaranteed to be 127.x.x.x (any will work, 0.0.1 is standard) on any IPv4 machine and ::1 on any IPv6 machine.
You probably want to extend this test to cover all of the IPv4 possibilities.
src/scheduler/scheduler.cpp
<https://reviews.apache.org/r/25055/#comment89948>
worth a net::isLoopback() method?
- Dominic Hamon
On Aug. 25, 2014, 7:49 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25055/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 7:49 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added logging when master/slaves/frameworks bind to loopback address.
>
>
> Diffs
> -----
>
> src/master/master.cpp 18464baad0864ae890d91097035edf8c49b6f60c
> src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
> src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
> src/slave/slave.cpp 6253a5dcde543ff448ad2e710a74892620e3bb87
>
> Diff: https://reviews.apache.org/r/25055/diff/
>
>
> Testing
> -------
>
> tested locally.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 25055: Added logging when master/slaves/frameworks
bind to loopback address.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25055/#review51491
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Aug. 26, 2014, 2:49 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25055/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 2:49 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added logging when master/slaves/frameworks bind to loopback address.
>
>
> Diffs
> -----
>
> src/master/master.cpp 18464baad0864ae890d91097035edf8c49b6f60c
> src/sched/sched.cpp 447b96fd88111536fdd7704abd078cc16b5c7943
> src/scheduler/scheduler.cpp b7ce4de4b01a898bb6763dde070fe521e142ee6c
> src/slave/slave.cpp 6253a5dcde543ff448ad2e710a74892620e3bb87
>
> Diff: https://reviews.apache.org/r/25055/diff/
>
>
> Testing
> -------
>
> tested locally.
>
>
> Thanks,
>
> Vinod Kone
>
>