You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/03/02 12:09:11 UTC

[GitHub] [systemds] Baunsgaard commented on pull request #1531: [SYSTEMDS-2996] countDistinctApprox Builtin function

Baunsgaard commented on pull request #1531:
URL: https://github.com/apache/systemds/pull/1531#issuecomment-1056857662


   Hi @BACtaki
   I really like your commit, and have now merged your PR while doing some minor cleanup in the process. (tabs vs spaces, imports etc.)
   
   The changes are moved to a new PR to see if the commit works in all the tests (i think they do) and once it parses it will go to main. If you still want to you can work on the processing without slicing the matrix, i think one cool design would be to extend the 
   matrix sketch interface to do col or row aggregate directly on a matrix. instead of having the getMatrixValue() function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org