You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Norbert Luksa (Code Review)" <ge...@cloudera.org> on 2020/03/03 09:05:31 UTC
[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15347
Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
......................................................................
IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
TupleRowCompareTest.DecimalTest crashes on release build
because of a faulty test. The problem occures with Decimal16Value
when the test tries to copy the values into the tuple in FillMem().
The solution is to use memcpy to avoid gcc generating unaligned
instructions like movaps for int128_t. They would raise SegmentFault
when addresses are not aligned to 16 bytes. This works with the
other types as well.
Tests:
- Run TupleRowCompareTest.
Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
---
M be/src/util/tuple-row-compare-test.cc
1 file changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/15347/1
--
To view, visit http://gerrit.cloudera.org:8080/15347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Gerrit-Change-Number: 15347
Gerrit-PatchSet: 1
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15347 )
Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
......................................................................
IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
TupleRowCompareTest.DecimalTest crashes on release build
because of a faulty test. The problem occures with Decimal16Value
when the test tries to copy the values into the tuple in FillMem().
The solution is to use memcpy to avoid gcc generating unaligned
instructions like movaps for int128_t. They would raise SegmentFault
when addresses are not aligned to 16 bytes. This works with the
other types as well.
Tests:
- Run TupleRowCompareTest.
Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Reviewed-on: http://gerrit.cloudera.org:8080/15347
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/tuple-row-compare-test.cc
1 file changed, 11 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Gerrit-Change-Number: 15347
Gerrit-PatchSet: 3
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15347 )
Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5443/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Gerrit-Change-Number: 15347
Gerrit-PatchSet: 2
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 10:06:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15347 )
Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Gerrit-Change-Number: 15347
Gerrit-PatchSet: 2
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 14:59:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15347 )
Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Gerrit-Change-Number: 15347
Gerrit-PatchSet: 2
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 10:06:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15347 )
Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Gerrit-Change-Number: 15347
Gerrit-PatchSet: 1
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 09:57:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15347 )
Change subject: IMPALA-9447: Fix for TupleRowCompareTest.DecimalTest crash
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5400/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2a53c88b57cec3a0bfcf02c492fbb560a80682d
Gerrit-Change-Number: 15347
Gerrit-PatchSet: 1
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Mar 2020 09:51:17 +0000
Gerrit-HasComments: No