You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/08/21 17:01:18 UTC

Review Request 24930: Brocken upgrade 1.6.0->1.7.0 and 1.6.1->1.7.0 after renaming of "value" column

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24930/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-6975
    https://issues.apache.org/jira/browse/AMBARI-6975


Repository: ambari


Description
-------

After "value" column was renamed to "sequence_value" in ambari_sequence table, we should rename this column name in DML for 1.6.0 and 1.6.1 too. For 1.5.0 i have already fixed that(soon will commit it).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java d3fdd3b 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java c23f611 

Diff: https://reviews.apache.org/r/24930/diff/


Testing
-------

in progress


Thanks,

Vitalyi Brodetskyi


Re: Review Request 24930: Brocken upgrade 1.6.0->1.7.0 and 1.6.1->1.7.0 after renaming of "value" column

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24930/#review51179
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Aug. 21, 2014, 3:39 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24930/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 3:39 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-6975
>     https://issues.apache.org/jira/browse/AMBARI-6975
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After "value" column was renamed to "sequence_value" in ambari_sequence table, we should rename this column name in DML for 1.6.0 and 1.6.1 too. For 1.5.0 i have already fixed that(soon will commit it).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java d3fdd3b 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java c23f611 
> 
> Diff: https://reviews.apache.org/r/24930/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> [INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-groovy-shell ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: src/main/resources/elephant.txt
> [INFO] Exclude: src/test/resources/2columns
> [INFO] Exclude: src/test/resources/3columns
> [INFO] Exclude: src/test/resources/testBlueprint.json
> [INFO] 31 resources included (use -debug for more details)
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 31 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [8.610s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.709s]
> [INFO] Ambari Web ........................................ SUCCESS [43.664s]
> [INFO] Ambari Views ...................................... SUCCESS [4.673s]
> [INFO] Ambari Admin View ................................. SUCCESS [20.867s]
> [INFO] Ambari Server ..................................... SUCCESS [38:55.069s]
> [INFO] Ambari Agent ...................................... SUCCESS [19.269s]
> [INFO] Ambari Client ..................................... SUCCESS [0.074s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.800s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [16.253s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.100s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.121s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [8.384s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 41:00.559s
> [INFO] Finished at: Thu Aug 21 17:26:06 FET 2014
> [INFO] Final Memory: 35M/170M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 24930: Brocken upgrade 1.6.0->1.7.0 and 1.6.1->1.7.0 after renaming of "value" column

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24930/
-----------------------------------------------------------

(Updated Сер. 21, 2014, 3:39 після полудня)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-6975
    https://issues.apache.org/jira/browse/AMBARI-6975


Repository: ambari


Description
-------

After "value" column was renamed to "sequence_value" in ambari_sequence table, we should rename this column name in DML for 1.6.0 and 1.6.1 too. For 1.5.0 i have already fixed that(soon will commit it).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java d3fdd3b 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java c23f611 

Diff: https://reviews.apache.org/r/24930/diff/


Testing (updated)
-------

[INFO] 
[INFO] --- apache-rat-plugin:0.10:check (default) @ ambari-groovy-shell ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/main/resources/elephant.txt
[INFO] Exclude: src/test/resources/2columns
[INFO] Exclude: src/test/resources/3columns
[INFO] Exclude: src/test/resources/testBlueprint.json
[INFO] 31 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 31 licence.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [8.610s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.709s]
[INFO] Ambari Web ........................................ SUCCESS [43.664s]
[INFO] Ambari Views ...................................... SUCCESS [4.673s]
[INFO] Ambari Admin View ................................. SUCCESS [20.867s]
[INFO] Ambari Server ..................................... SUCCESS [38:55.069s]
[INFO] Ambari Agent ...................................... SUCCESS [19.269s]
[INFO] Ambari Client ..................................... SUCCESS [0.074s]
[INFO] Ambari Python Client .............................. SUCCESS [0.800s]
[INFO] Ambari Groovy Client .............................. SUCCESS [16.253s]
[INFO] Ambari Shell ...................................... SUCCESS [0.100s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.121s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [8.384s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 41:00.559s
[INFO] Finished at: Thu Aug 21 17:26:06 FET 2014
[INFO] Final Memory: 35M/170M
[INFO] ------------------------------------------------------------------------


Thanks,

Vitalyi Brodetskyi