[GitHub] [curator] eolivelli commented on a change in pull request #409: CURATOR-633: Fix backward compatibility in tests

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #409:
URL: https://github.com/apache/curator/pull/409#discussion_r815356978



##########
File path: curator-framework/src/test/java/org/apache/curator/framework/state/TestConnectionStateManager.java
##########
@@ -91,7 +92,10 @@ public void stateChanged(CuratorFramework client, ConnectionState newState)
     }
 
     @Test
-    public void testConnectionStateRecoversFromUnexpectedExpiredConnection() throws Exception {
+    void testConnectionStateRecoversFromUnexpectedExpiredConnection() throws Exception {

Review comment:
       Maybe @tisonkun you are suggesting to create a set of tests that run only against zk 3.6+
   That is to generalise the approach of this fix.
   
   Probably we can create a annotation a little junit extension.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org