You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/11 07:54:05 UTC
[GitHub] [apisix] spacewander opened a new pull request #2218: bugfix: load yaml config in privileged agent
spacewander opened a new pull request #2218:
URL: https://github.com/apache/apisix/pull/2218
Fix #2186.
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] haifeng9414 commented on pull request #2218: bugfix: load yaml config in privileged agent
Posted by GitBox <gi...@apache.org>.
haifeng9414 commented on pull request #2218:
URL: https://github.com/apache/apisix/pull/2218#issuecomment-691407782
Privileged processes do not process user requests, I think there is no need to create a timer in init_worker phase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #2218: bugfix: load yaml config in privileged agent
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2218:
URL: https://github.com/apache/apisix/pull/2218#issuecomment-691504706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] haifeng9414 commented on pull request #2218: bugfix: load yaml config in privileged agent
Posted by GitBox <gi...@apache.org>.
haifeng9414 commented on pull request #2218:
URL: https://github.com/apache/apisix/pull/2218#issuecomment-691407782
Privileged processes do not process user requests, I think there is no need to create a timer in init_worker phase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #2218: bugfix: load yaml config in privileged agent
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2218:
URL: https://github.com/apache/apisix/pull/2218#issuecomment-691504706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] haifeng9414 commented on pull request #2218: bugfix: load yaml config in privileged agent
Posted by GitBox <gi...@apache.org>.
haifeng9414 commented on pull request #2218:
URL: https://github.com/apache/apisix/pull/2218#issuecomment-691407782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #2218: bugfix: load yaml config in privileged agent
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2218:
URL: https://github.com/apache/apisix/pull/2218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #2218: bugfix: load yaml config in privileged agent
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2218:
URL: https://github.com/apache/apisix/pull/2218#issuecomment-691504706
@haifeng9414
Plugin run in privileged agent might need to know the configure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org