You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sachingoel0101 <gi...@git.apache.org> on 2015/11/01 13:33:42 UTC
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1313
[FLINK-2939][web-dashboard] Add support to cancel jobs from the dashboard
Cancel button placement (open for discussion and/or any changes):
After cancelling:
Also includes some documentation fixes for the web frontend project to reflect the recent changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingoel0101/flink cancel_button
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1313
----
commit 29a488d1e5da9bf8e431ab40c8a23f8ee3e5e9dd
Author: Sachin Goel <sa...@gmail.com>
Date: 2015-11-01T10:24:13Z
[FLINK-2939][web-dashboard] Add support for cancelling jobs from the
dashboard
commit 77268771f6228ba75e22366ff3dc71124e48ba9e
Author: Sachin Goel <sa...@gmail.com>
Date: 2015-11-01T12:23:53Z
[hotfix] Fix README for flink-runtime-web to reflect the latest changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153305865
@StephanEwen Sorry, didn't see your post. I filed a follow-up JIRA for this: https://issues.apache.org/jira/browse/FLINK-2957
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1313#discussion_r43646999
--- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
$interval.cancel(refresher)
+ $scope.cancelJob = (cancelEvent) ->
+ angular.element(cancelEvent.currentTarget).removeClass('label-danger').addClass('label-info').html('Cancelling...')
--- End diff --
I wanted the button to have an *info* color while the job is being cancelled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152977663
@StephanEwen that's a good point. I've already pushed a fix. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153037113
I would like to merge this soon. Cancellation jobs from the web frontend has been requested several times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153033461
>Hovering over the cross reveals the word cancel.
Could we also have a button labelled "Cancel Job"? That way people don't even have to hover over things to get the meaning...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153192822
Much better. Is there a way of making this thing look more like a button? Right now it looks very much like a label and I would not think of trying to click it...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152943948
This goes a bit against the idea of REST. If you "GET" a certain URL, it should not affect the state of the system you query.
If we want to make that action part of the REST API, we should probably add a "DELETE" action for the URL "jobs/<jobid>".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152847408
Thanks! Not sure users will see the "X" in the corner and understand it's for cancelling jobs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1313#discussion_r43647947
--- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
$interval.cancel(refresher)
+ $scope.cancelJob = (cancelEvent) ->
+ angular.element(cancelEvent.currentTarget).removeClass('label-danger').addClass('label-info').html('Cancelling...')
--- End diff --
Ah I see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153303602
@StephanEwen , since this is already merged, I'll push another commit and point you to it for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1313#discussion_r43646752
--- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.ctrl.coffee ---
@@ -70,6 +70,10 @@ angular.module('flinkApp')
$interval.cancel(refresher)
+ $scope.cancelJob = (cancelEvent) ->
+ angular.element(cancelEvent.currentTarget).removeClass('label-danger').addClass('label-info').html('Cancelling...')
--- End diff --
Why do you have to remove the 'label-danger' class?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153089967
Sure. No problem. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153058657
Thank you for noticing that @mxm. Will push a commit to address all your comments in a little while.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-152904731
Hovering over the cross reveals the word cancel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2939][web-dashboard] Add support to can...
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1313#issuecomment-153068875
Here are the new screenshots:
Before:
During:
After:
@mxm Can you look this over again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---