Re: Query about From header in CXF

[Eoghan Glynn <eo...@gmail.com>]

I guess the only justification for not decoding the <wsa:From> is that
we don't use it internally in the CXF dispatch logic.

But I guess applications or custom interceptors may be interested in
this header, so we should really decode it.

Please file a JIRA, it should be trivial to fix. Or else submit a
patch if you're feeling adventurous :)

Cheers,
Eoghan

2009/4/6 Andrew Dinn <ad...@redhat.com>:
> I am using CXF inside JBoss Web Services 3.1.0 which is based on CXF 2.1.4.
> I have a client which uses WSAddressing. It attaches an AddressingProperties
> object to the outgoing request context in order to specify From, To,
> ReplyTo, FaultTo etc addresses. My server successfully retrieves the
> incoming AddressingProperties from the message context. However, I was
> surprised to find that on the server end the From address was not set even
> though I had supplied a value on the client side.
>
> On looking at the code for MAPCodec I noticed that the encode (outbound)
> method inserts a From header but the decode(inbound) method does attempt to
> retrieve the From header. Is this accidental or deliberate?
>
> If the former then has it been fixed in a later release?
>
> If the latter any rationale for this behaviour?
>
> regards,
>
>
> Andrew Dinn
> -----------
>
>
>

Re: Query about From header in CXF

[Eoghan Glynn <eo...@gmail.com>]

Thanks Andrew!

I've committed the fix and also added some unit test coverage.

http://svn.apache.org/viewvc?view=rev&revision=763272

Cheers,
Eoghan

2009/4/7 Andrew Dinn <ad...@redhat.com>:
> Eoghan Glynn wrote:
>>
>> I guess the only justification for not decoding the <wsa:From> is that
>> we don't use it internally in the CXF dispatch logic.
>>
>> But I guess applications or custom interceptors may be interested in
>> this header, so we should really decode it.
>
> Yes indeed. For example, the WS-AT spec (which I am currently implementing
> on top of JBossWS/CXF) necessitates the ability to set and retrieve the SOAP
> From header.
>
>> Please file a JIRA, it should be trivial to fix. Or else submit a
>> patch if you're feeling adventurous :)
>
> I raised CXF-2161. It includes a tested patch.
>
> regards,
>
>
> Andrew Dinn
> -----------
>

Re: Query about From header in CXF

[Andrew Dinn <ad...@redhat.com>]

Eoghan Glynn wrote:
> I guess the only justification for not decoding the <wsa:From> is that
> we don't use it internally in the CXF dispatch logic.
> 
> But I guess applications or custom interceptors may be interested in
> this header, so we should really decode it.

Yes indeed. For example, the WS-AT spec (which I am currently 
implementing on top of JBossWS/CXF) necessitates the ability to set and 
retrieve the SOAP From header.

> Please file a JIRA, it should be trivial to fix. Or else submit a
> patch if you're feeling adventurous :)

I raised CXF-2161. It includes a tested patch.

regards,


Andrew Dinn
-----------