[GitHub] [doris] morningman commented on a diff in pull request #14425: [chore](BE) add more log for better tracing for be write

[GitBox <gi...@apache.org>]

morningman commented on code in PR #14425:
URL: https://github.com/apache/doris/pull/14425#discussion_r1027303297


##########
be/src/olap/memtable_flush_executor.cpp:
##########
@@ -42,7 +42,10 @@ std::ostream& operator<<(std::ostream& os, const FlushStatistic& stat) {
 OLAPStatus FlushToken::submit(const std::shared_ptr<MemTable>& memtable) {
     RETURN_NOT_OK(_flush_status.load());
     int64_t submit_task_time = MonotonicNanos();
-    _flush_token->submit_func(std::bind(&FlushToken::_flush_memtable, this, memtable, submit_task_time));
+    auto st = _flush_token->submit_func(std::bind(&FlushToken::_flush_memtable, this, memtable, submit_task_time));
+    if (UNLIKELY(!st.ok())) {
+        return OLAP_ERR_OTHER_ERROR;

Review Comment:
   Better print st.get_error_msg() here.



##########
be/src/exec/tablet_sink.cpp:
##########
@@ -503,6 +516,8 @@ void NodeChannel::try_send_batch(RuntimeState* state) {
 
     // tablet_ids has already set when add row
     request.set_packet_seq(_next_packet_seq);
+    LOG(INFO) << "try to send " << row_batch->num_rows() << " row to " << this->_node_id

Review Comment:
   That will print too much logs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org