You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/04 12:00:27 UTC

[GitHub] [camel-quarkus] Chexpir opened a new issue #3436: auto-create-queue is not applied to deadLetterChannel method

Chexpir opened a new issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436


   Migrating to the latest (camel-quarkus 2.6.0 with camel-aws2-sqs:3.14.0) in other projects, I added
   `camel.component.aws2-sqs.auto-create-queue=true`
   to work.
   
   In this second project I am migrating, it is failing in tests and locally because this settings does not apply to dead queue letters.
   
   It works with
   ```
   from("aws2-sqs://nameofthequeue")
                   .process(updateObjectProcessor);
   ```
   but it does not work with
   ```
   errorHandler(deadLetterChannel("aws2-sqs://nameoftheDLqueue")
                   .log("Error processing message and sending to the Dead Letter Queue: Body: " + body())
                   .useOriginalMessage());
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] Chexpir commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
Chexpir commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1004864051


   @JiriOndrusek Temporary working solution for me is the following (adding sqsClient into camel Registry and explicitly adding it to the camel route):
   ```
           camelContext.getRegistry().bind("sqsClient", sqsClient);
   
           errorHandler(deadLetterChannel("aws2-sqs://nameoftheDLqueue?amazonSQSClient=#sqsClient")
                   .log("Error processing message and sending to the Dead Letter Queue: Body: " + body())
                   .useOriginalMessage());
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1008673158


   Problem is fixed on camel side (https://github.com/apache/camel/commit/4007b745170b69f81d47933e57d89a9ffd90c1a4)
   I'll add tests into camel-quarkus and also I'll fix some problems with other aws2 tests (discovered during this investigation)
   
   @Chexpir next cq release will contain camel with the fix and you'll be able to remove your workaround.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1004871006


   @Chexpir thanks for the information. I'll try to simulate problem on my machine and will try to find a solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton closed issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
jamesnetherton closed issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] Chexpir commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
Chexpir commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1005464022


   @JiriOndrusek thanks for spending time on this!
   
   Yes, it is the same error I was seeing myself.
   
   Yes, I am using the quarkus client (2.6.1.Final) and I was not doing the 2 steps mentioned in your link, but I found that documentation and did test with that specific configuration (@unremovable tag and apache sync-client type) before opening the bug, and it was still failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1004921263


   @Chexpir I' was able to simulate an error. Probably the same as you are seeing:
   ```
   Caused by: java.lang.IllegalArgumentException: AmazonSQSClient or accessKey and secretKey must be specified.
   	at org.apache.camel.component.aws2.sqs.Sqs2Component.createEndpoint(Sqs2Component.java:73)
   	at org.apache.camel.support.DefaultComponent.createEndpoint(DefaultComponent.java:171)
   	at org.apache.camel.impl.engine.AbstractCamelContext.doGetEndpoint(AbstractCamelContext.java:934)
   	... 72 more
   ```
   To be sure: Are you using quarkus client ? (defined via quarkus properties - https://camel.apache.org/camel-quarkus/2.6.x/reference/extensions/aws2-sqs.html#_optional_integration_with_quarkus_amazon_sqs)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1033521280


   Fixed in https://github.com/apache/camel-quarkus/commit/e3a41408e5dbabfbde54528ff1c7dacd88b921a4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] Chexpir edited a comment on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
Chexpir edited a comment on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1004864051


   @JiriOndrusek Temporary working solution for me is the following (adding sqsClient into camel Registry and explicitly adding it to the camel route):
   ```
   public void configure() {
           camelContext.getRegistry().bind("sqsClient", sqsClient);
   
           errorHandler(deadLetterChannel("aws2-sqs://nameoftheDLqueue?amazonSQSClient=#sqsClient")
                   .log("Error processing message and sending to the Dead Letter Queue: Body: " + body())
                   .useOriginalMessage());
   ....
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1005628302


   Problem is caused by the issue in Camel. I reported it - https://issues.apache.org/jira/browse/CAMEL-17437.
   
   I will also fix our junit tests, because this error can not be simulated on local aws (only real aws) even if deadletter is used. 
   
   @Chexpir your workaround is correct. Once camel issue is fixed, I'll let you know (so you can remove workaround).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] JiriOndrusek commented on issue #3436: deadLetterChannel does not work in BaseRouteBuilder configure method

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on issue #3436:
URL: https://github.com/apache/camel-quarkus/issues/3436#issuecomment-1020005680


   Could be closed. Reported issue is fixed in camel.
   Test is added in PR: https://github.com/apache/camel-quarkus/pull/3448.
   Following issues in tests are fixed in PR https://github.com/apache/camel-quarkus/pull/3458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org