You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2023/06/05 18:16:12 UTC

[GitHub] [incubator-hugegraph] liuxiaocs7 opened a new pull request, #2224: fix: jdbc ssl mode parameter

liuxiaocs7 opened a new pull request, #2224:
URL: https://github.com/apache/incubator-hugegraph/pull/2224

   `jdbc.sslmode` is not registered, we should use `jdbc.ssl_mode` instead.
   
   i see #2175 #2196 outputs have the same problem
   
   ```
   2023-06-06 02:04:22 [main] [WARN] o.a.h.c.HugeConfig - The config option 'jdbc.sslmode' is redundant, please ensure it has been registered
   2023-06-06 02:04:22 [main] [INFO] o.a.h.u.ConfigUtil - Scanning option 'graphs' directory './conf/graphs'
   2023-06-06 02:04:22 [main] [INFO] o.a.h.c.InitStore - Init graph with config file: .\conf\graphs\hugegraph.properties
   2023-06-06 02:04:22 [main] [WARN] o.a.h.c.HugeConfig - The config option 'jdbc.sslmode' is redundant, please ensure it has been registered
   ```
   
   https://github.com/apache/incubator-hugegraph/blob/bcf2a395cf8949c39a127facb404f75cf3842475/hugegraph-mysql/src/main/java/org/apache/hugegraph/backend/store/mysql/MysqlOptions.java#L101-L107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


[GitHub] [incubator-hugegraph] javeme merged pull request #2224: fix: jdbc ssl mode parameter redundant

Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme merged PR #2224:
URL: https://github.com/apache/incubator-hugegraph/pull/2224


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


[GitHub] [incubator-hugegraph] liuxiaocs7 commented on pull request #2224: fix: jdbc ssl mode parameter redundant

Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #2224:
URL: https://github.com/apache/incubator-hugegraph/pull/2224#issuecomment-1577993618

   > Good, and **check** if the log print **as expected** after we rename the config
   
   conf:
   
   ```
   backend=mysql
   serializer=mysql
   
   # mysql backend config
   jdbc.driver=com.mysql.cj.jdbc.Driver
   jdbc.url=jdbc:mysql://127.0.0.1:3306
   jdbc.username=root
   jdbc.password=xxxxxx
   jdbc.reconnect_max_times=3
   jdbc.reconnect_interval=3
   jdbc.ssl_mode=false
   ```
   
   logs:
   
   ```
   2023-06-06 14:26:04 [main] [INFO] o.a.h.u.ConfigUtil - Scanning option 'graphs' directory './conf/graphs'
   2023-06-06 14:26:04 [main] [INFO] o.a.h.c.InitStore - Init graph with config file: .\conf\graphs\hugegraph.properties
   2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlSessions - Connect to the jdbc url: 'jdbc:mysql://127.0.0.1:3306/?socketTimeout=0&useSSL=false'
   2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlStore - Failed to open database 'hugegraph', try to init database later
   2023-06-06 14:26:04 [main] [INFO] o.a.h.b.c.CacheManager - Init RamCache for 'schema-id-hugegraph' with capacity 10000
   2023-06-06 14:26:04 [main] [INFO] o.a.h.b.c.CacheManager - Init RamCache for 'schema-name-hugegraph' with capacity 10000
   2023-06-06 14:26:04 [main] [INFO] o.a.h.b.s.m.MysqlSessions - Connect to the jdbc url: 'jdbc:mysql://127.0.0.1:3306/?socketTimeout=0&useSSL=false'
   main dict load finished, time elapsed 421 ms
   model load finished, time elapsed 21 ms.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #2224: fix: jdbc ssl mode parameter redundant

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2224:
URL: https://github.com/apache/incubator-hugegraph/pull/2224#issuecomment-1577283133

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#2224](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2224?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6a2b24f) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/bcf2a395cf8949c39a127facb404f75cf3842475?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bcf2a39) will **decrease** coverage by `3.63%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2224      +/-   ##
   ============================================
   - Coverage     65.03%   61.40%   -3.63%     
     Complexity      977      977              
   ============================================
     Files           498      498              
     Lines         40681    40681              
     Branches       5681     5681              
   ============================================
   - Hits          26457    24982    -1475     
   - Misses        11597    13188    +1591     
   + Partials       2627     2511     -116     
   ```
   
   
   [see 35 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2224/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org