[GitHub] [spark] pan3793 commented on a diff in pull request #41077: [SPARK-43397][CORE] Log executor decommission duration

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #41077:
URL: https://github.com/apache/spark/pull/41077#discussion_r1186822944


##########
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala:
##########
@@ -1086,11 +1086,18 @@ private[spark] class TaskSchedulerImpl(
     case ExecutorKilled =>
       logInfo(s"Executor $executorId on $hostPort killed by driver.")
     case _: ExecutorDecommission =>
-      logInfo(s"Executor $executorId on $hostPort is decommissioned.")
+      logInfo(s"Executor $executorId on $hostPort is decommissioned after " +
+        s"${getDecommissionDurationMs(executorId)} ms.")

Review Comment:
   Please use `Utils.msDurationToString` to generate a more human-readable string representing a duration



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org