RE: cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/ webdav/method LockMethod.java PropFindMethod.java PropPatchMethod.java We bdavMethod.java

["Pill, Juergen" <Ju...@softwareag.com>]

Hello remy,

I am currently using Tomcat 3.2b4. I have not tried this with tomcat 4.0
yet.

I was wondering about this spontaneous changes already too, if I check in
some sources.

I have set my editor to expand all tabs to 4 blanks and remove trailing
blanks. I have the feeling some sources contain tabs, which would be
expanded into 8 blanks (at least the indention suggest this).

Next time I will check in, I will try to check in the sources without
changes before and after that check in the changes. This will make your (and
my) reading/merging more easy. 

Best regards

Juergen Pill

 -----Original Message-----
From: 	Remy Maucherat [mailto:remm@apache.org] 
Sent:	Monday, January 29, 2001 7:38 PM
To:	slide-dev@jakarta.apache.org
Subject:	Re: cvs commit:
jakarta-slide/src/webdav/server/org/apache/slide/webdav/method
LockMethod.java PropFindMethod.java PropPatchMethod.java WebdavMethod.java

> juergen     01/01/29 04:18:11
>
>   Modified:    src/webdav/server/org/apache/slide/webdav/method
>                         LockMethod.java PropFindMethod.java
>                         PropPatchMethod.java WebdavMethod.java
>   Log:
>   if the body of a propfind method was coded in utf-8, the body was not
properly decoded by the Reader wrapper.. Now a Stream is used and the bytes
are converted to a String using the right encoding. Remy, isn't this a
reader bug in Tomcat? The encoding stays quoted in speachmarks, do we want
to change this?

I have some trouble reading the diff, actually ;)

I found the place where the encoding is used.
+1.

Do you mean Tomcat (4.0 ?) returns a quoted String when asking for the
encoding name ?
If so, I think it has been fixed since then.

Remy

RE: cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/ webdav/method LockMethod.java PropFindMethod.java PropPatchMethod.java We bdavMethod.java

[Remy Maucherat <re...@betaversion.org>]

Quoting "Pill, Juergen" <Ju...@softwareag.com>:

> I am currently using Tomcat 3.2b4. I have not tried this with tomcat
> 4.0
> yet.

Perhaps you should update to 3.2.1 final. 4.0b1 has some annoying bugs 
especially with Slide's client library (they have been fixed), so you may want 
to wait for 4.0b2.

> I have set my editor to expand all tabs to 4 blanks and remove trailing
> blanks. I have the feeling some sources contain tabs, which would be
> expanded into 8 blanks (at least the indention suggest this).
> 
> Next time I will check in, I will try to check in the sources without
> changes before and after that check in the changes. This will make your
> (and
> my) reading/merging more easy.

Good idea, that would solve the reading problem :)

Remy