You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-cvs@xml.apache.org by mr...@apache.org on 2009/05/25 01:13:02 UTC

svn commit: r778254 - in /xml/commons/trunk/java/src/org/apache/xml/resolver: helpers/Namespaces.java readers/SAXCatalogReader.java

Author: mrglavas
Date: Sun May 24 23:13:02 2009
New Revision: 778254

URL: http://svn.apache.org/viewvc?rev=778254&view=rev
Log:
Minor performance improvement. String.length() == 0 tends to be slightly faster than String.equals("").

Modified:
    xml/commons/trunk/java/src/org/apache/xml/resolver/helpers/Namespaces.java
    xml/commons/trunk/java/src/org/apache/xml/resolver/readers/SAXCatalogReader.java

Modified: xml/commons/trunk/java/src/org/apache/xml/resolver/helpers/Namespaces.java
URL: http://svn.apache.org/viewvc/xml/commons/trunk/java/src/org/apache/xml/resolver/helpers/Namespaces.java?rev=778254&r1=778253&r2=778254&view=diff
==============================================================================
--- xml/commons/trunk/java/src/org/apache/xml/resolver/helpers/Namespaces.java (original)
+++ xml/commons/trunk/java/src/org/apache/xml/resolver/helpers/Namespaces.java Sun May 24 23:13:02 2009
@@ -83,7 +83,7 @@
 	    return null;
 	}
 
-	if (prefix.equals("")) {
+	if (prefix.length() == 0) {
 	    if (((Element) node).hasAttribute("xmlns")) {
 		return ((Element) node).getAttribute("xmlns");
 	    }

Modified: xml/commons/trunk/java/src/org/apache/xml/resolver/readers/SAXCatalogReader.java
URL: http://svn.apache.org/viewvc/xml/commons/trunk/java/src/org/apache/xml/resolver/readers/SAXCatalogReader.java?rev=778254&r1=778253&r2=778254&view=diff
==============================================================================
--- xml/commons/trunk/java/src/org/apache/xml/resolver/readers/SAXCatalogReader.java (original)
+++ xml/commons/trunk/java/src/org/apache/xml/resolver/readers/SAXCatalogReader.java Sun May 24 23:13:02 2009
@@ -331,7 +331,7 @@
       }
 
       String namespaceURI = null;
-      if (prefix.equals("")) {
+      if (prefix.length() == 0) {
 	namespaceURI = atts.getValue("xmlns");
       } else {
 	namespaceURI = atts.getValue("xmlns:" + prefix);