You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by GitBox <gi...@apache.org> on 2026/06/05 08:16:10 UTC

[GH] (grails-core/feat/gsp-rendering-observability): Workflow run "CodeQL" failed!

The GitHub Actions job "CodeQL" on grails-core.git/feat/gsp-rendering-observability has failed.
Run started by GitHub user codeconsole (triggered by codeconsole).

Head commit for run:
f1c5ea343c1f6b8cd6a0410a206cc4de21e1539f / Scott Murphy Heiberg <sc...@alwaysvip.com>
Add Micrometer Observation instrumentation for GSP view rendering

Wraps GroovyPageView rendering in a 'gsp.view' Observation, so each GSP page
render becomes a timer (and, under a tracing bridge, a span nested in the request
trace) — answering how much of a request is spent rendering the GSP.

Follows the Micrometer/Spring instrumentation pattern:
- GroovyPageObservationContext carries the view URI
- GroovyPageObservationDocumentation documents the gsp.view observation and its
  low-cardinality keys (gsp.view, error)
- GroovyPageObservationConvention + DefaultGroovyPageObservationConvention build the
  name / contextualName / KeyValues, and are overridable
- GroovyPageView wraps renderTemplate via GSP_VIEW.observation(...) with a NOOP
  fast-path; GroovyPageViewResolver resolves the ObservationRegistry from the
  application context (NOOP fallback) and sets it on each view

GroovyPageViewObservationSpec verifies the recorded observation name/tags, the
NOOP no-op path, and the error key on a failed render.

No new runtime dependency — micrometer-observation is already on the classpath
(Spring 6); zero overhead when no ObservationRegistry bean is present.

Report URL: https://github.com/apache/grails-core/actions/runs/27003433279

With regards,
GitHub Actions via GitBox