You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/01 06:02:23 UTC
[GitHub] [incubator-yunikorn-k8shim] wilfred-s opened a new pull request #209: [YUNIKORN-369] Set the default go version to 1.15
wilfred-s opened a new pull request #209:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/209
Build changes to move to go 1.15 tool set.
Upgrade golangci-lint to the latest (also go 1.15 based)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #209: [YUNIKORN-369] Set the default go version to 1.15
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #209:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #209: [YUNIKORN-369] Set the default go version to 1.15
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #209:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/209#issuecomment-736246038
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209?src=pr&el=h1) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209?src=pr&el=desc) (c053f31) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/03f36354820033a22556f1c82d7be8ef815a99f4?el=desc) (03f3635) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 58.36% 58.29% -0.07%
==========================================
Files 33 33
Lines 2928 2928
==========================================
- Hits 1709 1707 -2
- Misses 1147 1149 +2
Partials 72 72
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `81.81% <0.00%> (-2.03%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209?src=pr&el=footer). Last update [03f3635...c053f31](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/209?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org