You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/21 17:20:53 UTC

[GitHub] [helix] xyuanlu commented on pull request #1986: Read cloud config from zk and propagate to HelixManagerProperty in ZkHelixManager constructor

xyuanlu commented on pull request #1986:
URL: https://github.com/apache/helix/pull/1986#issuecomment-1074184740


   > Test case looks good.. is there any other place where we may need to pull out TestZkHelixManager ? Overall LGTM
   
   Thanks for the review. 
   The class TestZkHelixManager is only for retrieving managementProperty. I think other test class could implement their own local class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org