You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/05/17 03:46:58 UTC
Re: Review Request 58514: Update related tests in stout to support
protobuf 3.2.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58514/
-----------------------------------------------------------
(Updated May 17, 2017, 3:46 a.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
Rebase.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description
-------
Update related tests in stout to support protobuf 3.2.0.
Diffs (updated)
-----
3rdparty/stout/README.md f4e41aaacee4f88c708413e954553011229c75e4
3rdparty/stout/tests/protobuf_tests.pb.h 18870cde806c7bcb0a204de2a40555739adf777b
3rdparty/stout/tests/protobuf_tests.pb.cc b2458f0edcf679b2390f87ec8c4bee2b16e71d70
Diff: https://reviews.apache.org/r/58514/diff/2/
Changes: https://reviews.apache.org/r/58514/diff/1-2/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 58514: Update related tests in stout to support
protobuf 3.3.0.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58514/#review175550
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 19, 2017, 5:54 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58514/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 5:54 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Joseph Wu.
>
>
> Bugs: MESOS-7228
> https://issues.apache.org/jira/browse/MESOS-7228
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Command to regenerate:
> ```
> ./build/3rdparty/protobuf-3.3.0//src/protoc \
> -I 3rdparty/stout/tests \
> --cpp_out=3rdparty/stout/tests/ \
> 3rdparty/stout/tests/protobuf_tests.proto
> ```
>
>
> Diffs
> -----
>
> 3rdparty/stout/README.md f4e41aaacee4f88c708413e954553011229c75e4
> 3rdparty/stout/tests/protobuf_tests.pb.h 18870cde806c7bcb0a204de2a40555739adf777b
> 3rdparty/stout/tests/protobuf_tests.pb.cc b2458f0edcf679b2390f87ec8c4bee2b16e71d70
>
>
> Diff: https://reviews.apache.org/r/58514/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 58514: Update related tests in stout to support
protobuf 3.3.0.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58514/
-----------------------------------------------------------
(Updated May 19, 2017, 5:54 p.m.)
Review request for mesos, Anand Mazumdar and Joseph Wu.
Changes
-------
use 3.3.0 instead.
Summary (updated)
-----------------
Update related tests in stout to support protobuf 3.3.0.
Bugs: MESOS-7228
https://issues.apache.org/jira/browse/MESOS-7228
Repository: mesos
Description (updated)
-------
Command to regenerate:
```
./build/3rdparty/protobuf-3.3.0//src/protoc \
-I 3rdparty/stout/tests \
--cpp_out=3rdparty/stout/tests/ \
3rdparty/stout/tests/protobuf_tests.proto
```
Diffs (updated)
-----
3rdparty/stout/README.md f4e41aaacee4f88c708413e954553011229c75e4
3rdparty/stout/tests/protobuf_tests.pb.h 18870cde806c7bcb0a204de2a40555739adf777b
3rdparty/stout/tests/protobuf_tests.pb.cc b2458f0edcf679b2390f87ec8c4bee2b16e71d70
Diff: https://reviews.apache.org/r/58514/diff/3/
Changes: https://reviews.apache.org/r/58514/diff/2-3/
Testing
-------
Thanks,
Zhitao Li