You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Arrigo Marchiori <ar...@yahoo.it.INVALID> on 2022/02/18 20:05:48 UTC
Re: problem reading old XML formats with trunk
Hello Carl, All,
On Fri, Jan 07, 2022 at 04:57:20PM +0100, Arrigo Marchiori wrote:
> Hello Carl, All,
>
> I am branching the thread from here in order to prune less
> interesting parts.
>
> On Sun, Nov 14, 2021 at 10:12:05PM -0500, Carl Marcum wrote:
>
> > Hi All,
> >
> > On 11/14/21 5:05 PM, Matthias Seidel wrote:
> > > Hi Carl,
> > >
> > > Am 14.11.21 um 22:45 schrieb Carl Marcum:
> > > > Hi Matthias,
> > > >
> > > >
> > > > On 11/14/21 11:44 AM, Matthias Seidel wrote:
> > > > > Hi Carl,
> > > > >
> > > > > Am 14.11.21 um 17:36 schrieb Matthias Seidel:
> > > > > > Hi Carl,
> > > > > >
> > > > > > Am 14.11.21 um 17:31 schrieb Carl Marcum:
> > > > > > > Hi Matthias and All,
> > > > > > >
> > > > > > > On 11/14/21 9:10 AM, Matthias Seidel wrote:
> > > > > > > > Hi Carl,
> > > > > > > >
> > > > > > > > I only have a VM available with Xubuntu 18.04.6 and AOO42X, but
> > > > > > > > have no
> > > > > > > > problems opening and saving *.STW.
> > > > > > > Okay I'll build AOO42X and see if I have same issues as trunk.
> > > > > > >
> > > > > > > I recompiled trunk with
> > > > > > > --enable-crashdump=yes \
> > > > > > > --enable-dbgutil \
> > > > > > >
> > > > > > > and now I get a better error dialog for opening these file types:
> > > > > > > testSaveNewSTC.stc
> > > > > > > testSaveNewSXC.sxc
> > > > > > > ------------------
> > > > > > > Error: uno exception caught while importing:
> > > > > > > attempt to insert duplicate XML tag attribute: xmlns:svg
> > > > > > > From File
> > > > > > > <build-path-to>/openoffice/main/sc/source/filter/xml/xmlwrap.cxx at
> > > > > > > Line 365
> > > > > > > Abort ? (Yes=abort / No=ignore / Cancel=core dump)
> > > > > > I remember that we have a commit in trunk but not in AOO42X:
> > > > > >
> > > > > > https://github.com/apache/openoffice/pull/122
> > > > > >
> > > > > > Until now it has not been tested... Maybe that is the problem?
> > > > > I can confirm Read-Errors with AOO450 (trunk) on Windows with STW and
> > > > > SXW.
> > > > > No problems with AOO420 (AOO42X).
> > > > >
> > > > > This merge may need to be reverted...
> > > >
> > > > Thanks for checking.
> > > >
> > > > It might be better at this point to fix the code.
> > > That's why I asked for testing... ;-)
> > > > I'll do some bisecting and try to narrow it down.
> > > I am not sure if the code was ready, Arrigo might know better.
> >
> > I bisected it down to this one where it starts giving me the error which
> > makes sense according the the commit message:
> >
> > ebd28ad3a7fedadb378ee1596803008e8c6b383b is the first bad commit
> > commit ebd28ad3a7fedadb378ee1596803008e8c6b383b
> >
> > Raise an exception when attempting to add duplicate attributes
>
> The error is raised during parsing of file styles.xml, initial tag
> <office:document>, attribute
> xmlns:svg="http://openoffice.org/2000/svg"
>
> Method XMLDocumentTransformerContext_Impl::StartElement() considers
> individual XML attributes and, at the end, it adds the ones it
> considers missing.
>
> The xmlns:svg is considered missing because it does not have the
> expected _content_. Yes, the check is made on attribute contents,
> rather than attribute names.
>
> That attributs's content _should_ be the one indicated above, but the
> caller method XMLTransformerBase::startElement() has _just changed its
> content_ into
> "urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
>
> For this reason, method
> XMLDocumentTransformerContext_Impl::StartElement() tries to re-add the
> "xmlns:svg" element.
>
> The first solutions that come into my mind are:
>
> 1- have XMLDocumentTransformerContext_Impl::StartElement() consider
> element _names_ rather than values, or
>
> 2- have XMLDocumentTransformerContext_Impl::StartElement() look for
> the ``changed'' content (urn:etcetera) instead of the ``original''
> one (http://Etcetera)
>
> What is the best way to go?
I went for 2-
This problem should be fixed in trunk with commit
7462b7435704d287da295f8819ee4fd4bffded77
I could not run the tests, though, I think because they cannot
``type'' the string "@AOO" correctly.
My PC has an Italian keyboard, and I am seeing the tests type
"AOO
instead of
@AOO
maybe because the Italian layout has the quotes " above the 2 key?
Best regards,
--
Arrigo
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: problem reading old XML formats with trunk
Posted by Carl Marcum <cm...@apache.org>.
Hi Arrigo and All,
On 2/18/22 4:03 PM, Carl Marcum wrote:
> Hi Arrigo,
>
> On 2/18/22 3:05 PM, Arrigo Marchiori wrote:
>> Hello Carl, All,
>>
>> On Fri, Jan 07, 2022 at 04:57:20PM +0100, Arrigo Marchiori wrote:
>>
>>> Hello Carl, All,
>>>
>>> I am branching the thread from here in order to prune less
>>> interesting parts.
>>>
>>> On Sun, Nov 14, 2021 at 10:12:05PM -0500, Carl Marcum wrote:
>>>
>>>> Hi All,
>>>>
>>>> On 11/14/21 5:05 PM, Matthias Seidel wrote:
>>>>> Hi Carl,
>>>>>
>>>>> Am 14.11.21 um 22:45 schrieb Carl Marcum:
>>>>>> Hi Matthias,
>>>>>>
>>>>>>
>>>>>> On 11/14/21 11:44 AM, Matthias Seidel wrote:
>>>>>>> Hi Carl,
>>>>>>>
>>>>>>> Am 14.11.21 um 17:36 schrieb Matthias Seidel:
>>>>>>>> Hi Carl,
>>>>>>>>
>>>>>>>> Am 14.11.21 um 17:31 schrieb Carl Marcum:
>>>>>>>>> Hi Matthias and All,
>>>>>>>>>
>>>>>>>>> On 11/14/21 9:10 AM, Matthias Seidel wrote:
>>>>>>>>>> Hi Carl,
>>>>>>>>>>
>>>>>>>>>> I only have a VM available with Xubuntu 18.04.6 and AOO42X, but
>>>>>>>>>> have no
>>>>>>>>>> problems opening and saving *.STW.
>>>>>>>>> Okay I'll build AOO42X and see if I have same issues as trunk.
>>>>>>>>>
>>>>>>>>> I recompiled trunk with
>>>>>>>>> --enable-crashdump=yes \
>>>>>>>>> --enable-dbgutil \
>>>>>>>>>
>>>>>>>>> and now I get a better error dialog for opening these file types:
>>>>>>>>> testSaveNewSTC.stc
>>>>>>>>> testSaveNewSXC.sxc
>>>>>>>>> ------------------
>>>>>>>>> Error: uno exception caught while importing:
>>>>>>>>> attempt to insert duplicate XML tag attribute: xmlns:svg
>>>>>>>>> From File
>>>>>>>>> <build-path-to>/openoffice/main/sc/source/filter/xml/xmlwrap.cxx
>>>>>>>>> at
>>>>>>>>> Line 365
>>>>>>>>> Abort ? (Yes=abort / No=ignore / Cancel=core dump)
>>>>>>>> I remember that we have a commit in trunk but not in AOO42X:
>>>>>>>>
>>>>>>>> https://github.com/apache/openoffice/pull/122
>>>>>>>>
>>>>>>>> Until now it has not been tested... Maybe that is the problem?
>>>>>>> I can confirm Read-Errors with AOO450 (trunk) on Windows with
>>>>>>> STW and
>>>>>>> SXW.
>>>>>>> No problems with AOO420 (AOO42X).
>>>>>>>
>>>>>>> This merge may need to be reverted...
>>>>>> Thanks for checking.
>>>>>>
>>>>>> It might be better at this point to fix the code.
>>>>> That's why I asked for testing... ;-)
>>>>>> I'll do some bisecting and try to narrow it down.
>>>>> I am not sure if the code was ready, Arrigo might know better.
>>>> I bisected it down to this one where it starts giving me the error
>>>> which
>>>> makes sense according the the commit message:
>>>>
>>>> ebd28ad3a7fedadb378ee1596803008e8c6b383b is the first bad commit
>>>> commit ebd28ad3a7fedadb378ee1596803008e8c6b383b
>>>>
>>>> Raise an exception when attempting to add duplicate attributes
>>> The error is raised during parsing of file styles.xml, initial tag
>>> <office:document>, attribute
>>> xmlns:svg="http://openoffice.org/2000/svg"
>>>
>>> Method XMLDocumentTransformerContext_Impl::StartElement() considers
>>> individual XML attributes and, at the end, it adds the ones it
>>> considers missing.
>>>
>>> The xmlns:svg is considered missing because it does not have the
>>> expected _content_. Yes, the check is made on attribute contents,
>>> rather than attribute names.
>>>
>>> That attributs's content _should_ be the one indicated above, but the
>>> caller method XMLTransformerBase::startElement() has _just changed its
>>> content_ into
>>> "urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
>>>
>>> For this reason, method
>>> XMLDocumentTransformerContext_Impl::StartElement() tries to re-add the
>>> "xmlns:svg" element.
>>>
>>> The first solutions that come into my mind are:
>>>
>>> 1- have XMLDocumentTransformerContext_Impl::StartElement() consider
>>> element _names_ rather than values, or
>>>
>>> 2- have XMLDocumentTransformerContext_Impl::StartElement() look for
>>> the ``changed'' content (urn:etcetera) instead of the ``original''
>>> one (http://Etcetera)
>>>
>>> What is the best way to go?
>> I went for 2-
>>
>> This problem should be fixed in trunk with commit
>> 7462b7435704d287da295f8819ee4fd4bffded77
The tests on my trunk build now pass!
>>
>> I could not run the tests, though, I think because they cannot
>> ``type'' the string "@AOO" correctly.
>>
>> My PC has an Italian keyboard, and I am seeing the tests type
>> "AOO
>> instead of
>> @AOO
>> maybe because the Italian layout has the quotes " above the 2 key?
That could be the reason.
Maybe somehow the test must use en-US localization or keyboard layout.
I'll have to put that on my list of thing to look into.
>>
>> Best regards,
> I will run the tests against it and report my results.
Reported above.
Thanks for the fix!
Best regards,
Carl
>
> Thanks for working on this!
>
> Best regards,
> Carl
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: problem reading old XML formats with trunk
Posted by Carl Marcum <cm...@apache.org>.
Hi Arrigo,
On 2/18/22 3:05 PM, Arrigo Marchiori wrote:
> Hello Carl, All,
>
> On Fri, Jan 07, 2022 at 04:57:20PM +0100, Arrigo Marchiori wrote:
>
>> Hello Carl, All,
>>
>> I am branching the thread from here in order to prune less
>> interesting parts.
>>
>> On Sun, Nov 14, 2021 at 10:12:05PM -0500, Carl Marcum wrote:
>>
>>> Hi All,
>>>
>>> On 11/14/21 5:05 PM, Matthias Seidel wrote:
>>>> Hi Carl,
>>>>
>>>> Am 14.11.21 um 22:45 schrieb Carl Marcum:
>>>>> Hi Matthias,
>>>>>
>>>>>
>>>>> On 11/14/21 11:44 AM, Matthias Seidel wrote:
>>>>>> Hi Carl,
>>>>>>
>>>>>> Am 14.11.21 um 17:36 schrieb Matthias Seidel:
>>>>>>> Hi Carl,
>>>>>>>
>>>>>>> Am 14.11.21 um 17:31 schrieb Carl Marcum:
>>>>>>>> Hi Matthias and All,
>>>>>>>>
>>>>>>>> On 11/14/21 9:10 AM, Matthias Seidel wrote:
>>>>>>>>> Hi Carl,
>>>>>>>>>
>>>>>>>>> I only have a VM available with Xubuntu 18.04.6 and AOO42X, but
>>>>>>>>> have no
>>>>>>>>> problems opening and saving *.STW.
>>>>>>>> Okay I'll build AOO42X and see if I have same issues as trunk.
>>>>>>>>
>>>>>>>> I recompiled trunk with
>>>>>>>> --enable-crashdump=yes \
>>>>>>>> --enable-dbgutil \
>>>>>>>>
>>>>>>>> and now I get a better error dialog for opening these file types:
>>>>>>>> testSaveNewSTC.stc
>>>>>>>> testSaveNewSXC.sxc
>>>>>>>> ------------------
>>>>>>>> Error: uno exception caught while importing:
>>>>>>>> attempt to insert duplicate XML tag attribute: xmlns:svg
>>>>>>>> From File
>>>>>>>> <build-path-to>/openoffice/main/sc/source/filter/xml/xmlwrap.cxx at
>>>>>>>> Line 365
>>>>>>>> Abort ? (Yes=abort / No=ignore / Cancel=core dump)
>>>>>>> I remember that we have a commit in trunk but not in AOO42X:
>>>>>>>
>>>>>>> https://github.com/apache/openoffice/pull/122
>>>>>>>
>>>>>>> Until now it has not been tested... Maybe that is the problem?
>>>>>> I can confirm Read-Errors with AOO450 (trunk) on Windows with STW and
>>>>>> SXW.
>>>>>> No problems with AOO420 (AOO42X).
>>>>>>
>>>>>> This merge may need to be reverted...
>>>>> Thanks for checking.
>>>>>
>>>>> It might be better at this point to fix the code.
>>>> That's why I asked for testing... ;-)
>>>>> I'll do some bisecting and try to narrow it down.
>>>> I am not sure if the code was ready, Arrigo might know better.
>>> I bisected it down to this one where it starts giving me the error which
>>> makes sense according the the commit message:
>>>
>>> ebd28ad3a7fedadb378ee1596803008e8c6b383b is the first bad commit
>>> commit ebd28ad3a7fedadb378ee1596803008e8c6b383b
>>>
>>> Raise an exception when attempting to add duplicate attributes
>> The error is raised during parsing of file styles.xml, initial tag
>> <office:document>, attribute
>> xmlns:svg="http://openoffice.org/2000/svg"
>>
>> Method XMLDocumentTransformerContext_Impl::StartElement() considers
>> individual XML attributes and, at the end, it adds the ones it
>> considers missing.
>>
>> The xmlns:svg is considered missing because it does not have the
>> expected _content_. Yes, the check is made on attribute contents,
>> rather than attribute names.
>>
>> That attributs's content _should_ be the one indicated above, but the
>> caller method XMLTransformerBase::startElement() has _just changed its
>> content_ into
>> "urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0"
>>
>> For this reason, method
>> XMLDocumentTransformerContext_Impl::StartElement() tries to re-add the
>> "xmlns:svg" element.
>>
>> The first solutions that come into my mind are:
>>
>> 1- have XMLDocumentTransformerContext_Impl::StartElement() consider
>> element _names_ rather than values, or
>>
>> 2- have XMLDocumentTransformerContext_Impl::StartElement() look for
>> the ``changed'' content (urn:etcetera) instead of the ``original''
>> one (http://Etcetera)
>>
>> What is the best way to go?
> I went for 2-
>
> This problem should be fixed in trunk with commit
> 7462b7435704d287da295f8819ee4fd4bffded77
>
> I could not run the tests, though, I think because they cannot
> ``type'' the string "@AOO" correctly.
>
> My PC has an Italian keyboard, and I am seeing the tests type
> "AOO
> instead of
> @AOO
> maybe because the Italian layout has the quotes " above the 2 key?
>
> Best regards,
I will run the tests against it and report my results.
Thanks for working on this!
Best regards,
Carl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org