You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bf...@apache.org on 2013/11/14 21:17:05 UTC
git commit: updated refs/heads/master to 5fb7c29
Updated Branches:
refs/heads/master ac649b43e -> 5fb7c2972
Fixed issue with detail view fields marked as 'isPassword' not being obfuscated
CLOUDSTACK-5111
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/5fb7c297
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/5fb7c297
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/5fb7c297
Branch: refs/heads/master
Commit: 5fb7c297260b5fb61781514c412bfad88dd86870
Parents: ac649b4
Author: Chris Suich <ch...@netapp.com>
Authored: Fri Nov 8 15:30:05 2013 -0500
Committer: Brian Federle <bf...@gmail.com>
Committed: Thu Nov 14 12:17:00 2013 -0800
----------------------------------------------------------------------
ui/scripts/ui/widgets/detailView.js | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/5fb7c297/ui/scripts/ui/widgets/detailView.js
----------------------------------------------------------------------
diff --git a/ui/scripts/ui/widgets/detailView.js b/ui/scripts/ui/widgets/detailView.js
index 65f71b3..b0ebaa9 100644
--- a/ui/scripts/ui/widgets/detailView.js
+++ b/ui/scripts/ui/widgets/detailView.js
@@ -462,7 +462,9 @@
$value.html(_s(
$input.attr('value')
));
- else if ($input.is('input[type=checkbox]')) {
+ else if ($input.is('input[type=password]')) {
+ $value.html('');
+ } else if ($input.is('input[type=checkbox]')) {
var val = $input.is(':checked');
$value.data('detail-view-boolean-value', _s(val));
@@ -628,6 +630,7 @@
var isBoolean = $value.data('detail-view-editable-boolean');
var data = !isBoolean ? cloudStack.sanitizeReverse($value.html()) : $value.data('detail-view-boolean-value');
var rules = $value.data('validation-rules') ? $value.data('validation-rules') : {};
+ var isPassword = $value.data('detail-view-is-password');
$value.html('');
@@ -667,7 +670,7 @@
$value.append(
$('<input>').attr({
name: name,
- type: 'text',
+ type: isPassword ? 'password' : 'text',
value: data
}).addClass('disallowSpecialCharacters').data('original-value', data)
);
@@ -1004,6 +1007,8 @@
} else if (value.isBoolean) {
$value.data('detail-view-editable-boolean', true);
$value.data('detail-view-boolean-value', content == 'Yes' ? true : false);
+ } else {
+ $value.data('detail-view-is-password', value.isPassword);
}
return true;