You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/06/01 18:18:57 UTC
[GitHub] [nifi] mattyb149 commented on a change in pull request #3231:
NIFI-5902 Added GeoEnrichIPRecord.
mattyb149 commented on a change in pull request #3231: NIFI-5902 Added GeoEnrichIPRecord.
URL: https://github.com/apache/nifi/pull/3231#discussion_r289614365
##########
File path: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIPRecord.java
##########
@@ -0,0 +1,323 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors;
+
+import com.maxmind.geoip2.model.CityResponse;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.processors.maxmind.DatabaseReader;
+import org.apache.nifi.record.path.FieldValue;
+import org.apache.nifi.record.path.RecordPath;
+import org.apache.nifi.record.path.RecordPathResult;
+import org.apache.nifi.record.path.util.RecordPathCache;
+import org.apache.nifi.serialization.RecordReader;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordSchema;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.InetAddress;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@Tags({"geo", "enrich", "ip", "maxmind", "record"})
+@CapabilityDescription("Looks up geolocation information for an IP address and adds the geo information to FlowFile attributes. The "
+ + "geo data is provided as a MaxMind database. This version uses the NiFi Record API to allow large scale enrichment of record-oriented data sets. "
+ + "Each field provided by the MaxMind database can be directed to a field of the user's choosing by providing a record path for that field configuration. ")
+public class GeoEnrichIPRecord extends AbstractEnrichIP {
+ public static final PropertyDescriptor READER = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-record-reader")
+ .displayName("Record Reader")
+ .description("Record reader service to use for reading the flowfile contents.")
+ .required(true)
+ .identifiesControllerService(RecordReaderFactory.class)
+ .build();
+ public static final PropertyDescriptor WRITER = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-record-writer")
+ .displayName("Record Writer")
+ .description("Record writer service to use for enriching the flowfile contents.")
+ .required(true)
+ .identifiesControllerService(RecordSetWriterFactory.class)
+ .build();
+ public static final PropertyDescriptor IP_RECORD_PATH = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-ip-record-path")
+ .displayName("IP Address Record Path")
+ .description("The record path to retrieve the IP address for doing the lookup.")
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .required(true)
+ .build();
+ public static final PropertyDescriptor SPLIT_FOUND_NOT_FOUND = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-split-found-not-found")
+ .displayName("Separate Enriched From Not Enriched")
+ .description("Separate records that have been enriched from ones that have not. Default behavior is " +
+ "to send everything to the found relationship if even one record is enriched.")
+ .allowableValues("true", "false")
+ .defaultValue("false")
+ .required(true)
+ .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor GEO_CITY = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-city-record-path")
+ .displayName("City Record Path")
+ .description("Record path for putting the city identified for the IP address")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+ public static final PropertyDescriptor GEO_ACCURACY = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-accuracy-record-path")
+ .displayName("Accuracy Radius Record Path")
+ .description("Record path for putting the accuracy radius if provided by the database (in Kilometers)")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+ public static final PropertyDescriptor GEO_LATITUDE = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-latitude-record-path")
+ .displayName("Latitude Record Path")
+ .description("Record path for putting the latitude identified for this IP address")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+ public static final PropertyDescriptor GEO_LONGITUDE = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-longitude-record-path")
+ .displayName("Longitude Record Path")
+ .description("Record path for putting the longitude identified for this IP address")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+ public static final PropertyDescriptor GEO_COUNTRY = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-country-record-path")
+ .displayName("Country Record Path")
+ .description("Record path for putting the country identified for this IP address")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+ public static final PropertyDescriptor GEO_COUNTRY_ISO = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-country-iso-record-path")
+ .displayName("Country ISO Code Record Path")
+ .description("Record path for putting the ISO Code for the country identified")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+ public static final PropertyDescriptor GEO_POSTAL_CODE = new PropertyDescriptor.Builder()
+ .name("geo-enrich-ip-country-postal-record-path")
+ .displayName("Country Postal Code Record Path")
+ .description("Record path for putting the postal code for the country identified")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .build();
+
+ public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+ .name("original")
+ .description("The original input flowfile goes to this relationship regardless of whether the content was enriched or not.")
+ .build();
+
+ public static final Set<Relationship> RELATIONSHIPS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
+ REL_ORIGINAL, REL_FOUND, REL_NOT_FOUND
+ )));
+
+ public static final List<PropertyDescriptor> GEO_PROPERTIES = Collections.unmodifiableList(Arrays.asList(
+ GEO_CITY, GEO_ACCURACY, GEO_LATITUDE, GEO_LONGITUDE, GEO_COUNTRY, GEO_COUNTRY_ISO, GEO_POSTAL_CODE
+ ));
+
+ private static final List<PropertyDescriptor> DESCRIPTORS = Collections.unmodifiableList(Arrays.asList(
+ GEO_DATABASE_FILE, READER, WRITER, SPLIT_FOUND_NOT_FOUND, IP_RECORD_PATH, GEO_CITY, GEO_ACCURACY, GEO_LATITUDE,
+ GEO_LONGITUDE, GEO_COUNTRY, GEO_COUNTRY_ISO, GEO_POSTAL_CODE
+ ));
+
+ @Override
+ public Set<Relationship> getRelationships() {
+ return RELATIONSHIPS;
+ }
+
+ @Override
+ protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+ return DESCRIPTORS;
+ }
+
+ protected volatile RecordReaderFactory readerFactory;
+ protected volatile RecordSetWriterFactory writerFactory;
+ protected boolean splitOutput;
+
+ @Override
+ @OnScheduled
+ public void onScheduled(ProcessContext context) throws IOException {
+ super.onScheduled(context);
+
+ readerFactory = context.getProperty(READER).asControllerService(RecordReaderFactory.class);
+ writerFactory = context.getProperty(WRITER).asControllerService(RecordSetWriterFactory.class);
+ splitOutput = context.getProperty(SPLIT_FOUND_NOT_FOUND).asBoolean();
+ }
+
+ @Override
+ public void onTrigger(ProcessContext context, ProcessSession session) throws ProcessException {
+ FlowFile input = session.get();
+ if (input == null) {
+ return;
+ }
+
+ FlowFile output = session.create(input);
+ FlowFile notFound = splitOutput ? session.create(input) : null;
+ final DatabaseReader dbReader = databaseReaderRef.get();
+ try (InputStream is = session.read(input);
+ OutputStream os = session.write(output);
+ OutputStream osNotFound = splitOutput ? session.write(notFound) : null) {
+ RecordPathCache cache = new RecordPathCache(GEO_PROPERTIES.size() + 1);
+ Map<PropertyDescriptor, RecordPath> paths = new HashMap<>();
+ for (PropertyDescriptor descriptor : GEO_PROPERTIES) {
+ if (!context.getProperty(descriptor).isSet()) {
+ continue;
+ }
+ String rawPath = context.getProperty(descriptor).evaluateAttributeExpressions(input).getValue();
+ RecordPath compiled = cache.getCompiled(rawPath);
+ paths.put(descriptor, compiled);
+ }
+
+ String rawIpPath = context.getProperty(IP_RECORD_PATH).evaluateAttributeExpressions(input).getValue();
+ RecordPath ipPath = cache.getCompiled(rawIpPath);
+
+ RecordReader reader = readerFactory.createRecordReader(input, is, getLogger());
+ RecordSchema schema = writerFactory.getSchema(input.getAttributes(), null);
Review comment:
I'm fine with not doing the dynamic schema update, but you should still pass `reader.getSchema()` instead of `null` as the second argument here, otherwise you have to explicitly set the writer's schema rather than being able to inherit it from the reader (which may itself have inferred the schema, so you wouldn't necessarily know what to set as the writer's schema).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services