You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by Ken Giusti <kg...@redhat.com> on 2012/11/01 15:27:04 UTC

Re: review request: patch to cmake for windows builds

I've created a project branch "kgiusti-msvc2010" on the apache site - no need to use github.

Here is the current diff in all it's glory:

https://reviews.apache.org/r/7826/

-K

----- Original Message -----
> On Wed, 2012-10-31 at 13:46 -0400, Ken Giusti wrote:
> > Hi Cliff/Mary,
> > 
> > I'm trying to add support for building proton using Microsoft
> > Visual C++ express.  This patch updates cmake to enable generation
> > of the VC++ project files for proton.  Can you review and try it
> > out - let me know what you think?
> > 
> > Note that the patch only adds build support - the problems with
> > building proton on windows are not addressed.
> > 
> > The diff can be viewed here:
> > 
> > https://github.com/kgiusti/qpid-proton/compare/win7
> > 
> > And the changes are on the win7 branch of my github proton repo:
> > 
> > git://github.com/kgiusti/qpid-proton.git
> > 
> > -K
> 
> Is there a place you could put this diff so we could comment on it?
> 
> I have a bunch of comments and nowhere to put them!
> 
> Andrew
> 
> 
>