You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by Kami <gi...@git.apache.org> on 2015/03/07 16:59:45 UTC
[GitHub] libcloud pull request: [WIP] Support for AWS signature algorithm v...
GitHub user Kami opened a pull request:
https://github.com/apache/libcloud/pull/481
[WIP] Support for AWS signature algorithm v4 (continuation)
Continuation from https://github.com/apache/libcloud/pull/444/files#r25956437
The pull request is not finished yet, but it now works correctly with the "region" argument.
```bash
# -------- begin 140069208370896 request ----------
curl -i -X GET -H 'Host: ec2.us-east-1.amazonaws.com' -H 'X-LC-Request-ID: 140069208370896' -H 'Accept-Encoding: gzip,deflate' -H 'User-Agent: libcloud/0.17.1-dev (Amazon EC2) ' --compress 'https://ec2.us-east-1.amazonaws.com:443/?SignatureVersion=2&...&Action=DescribeInstances'
# -------- begin 140069208370896:140069213157064 response ----------
HTTP/1.1 200 OK
Content-Encoding: gzip
Transfer-Encoding: chunked
Vary: Accept-Encoding
Server: AmazonEC2
Date: Sat, 07 Mar 2015 15:44:39 GMT
Content-Type: text/xml;charset=UTF-8
e6
<?xml version="1.0" encoding="UTF-8"?>
<DescribeInstancesResponse xmlns="http://ec2.amazonaws.com/doc/2013-10-15/">
<requestId>59272782-d9ee-4367-91ee-c84dc782003f</requestId>
<reservationSet/>
</DescribeInstancesResponse>
0
# -------- begin 140696717963408 request ----------
curl -i -X GET -H 'Host: ec2.eu-central-1.amazonaws.com' -H 'Accept-Encoding: gzip,deflate' -H 'X-AMZ-Date: 20150307T155439Z' -H 'X-LC-Request-ID: 140696717963408' -H 'Authorization: AWS4-HMAC-SHA256 Credential=.../eu-central-1/ec2/aws4_request, SignedHeaders=accept-encoding;host;user-agent;x-amz-date, Signature...' -H 'User-Agent: libcloud/0.17.1-dev (Amazon EC2) ' --compress 'https://ec2.eu-central-1.amazonaws.com:443/?Action=DescribeInstances&Version=2013-10-15'
# -------- begin 140696717963408:140696722668144 response ----------
HTTP/1.1 200 OK
Content-Encoding: gzip
Transfer-Encoding: chunked
Vary: Accept-Encoding
Server: AmazonEC2
Date: Sat, 07 Mar 2015 15:54:39 GMT
Content-Type: text/xml;charset=UTF-8
e6
<?xml version="1.0" encoding="UTF-8"?>
<DescribeInstancesResponse xmlns="http://ec2.amazonaws.com/doc/2013-10-15/">
<requestId>f4b4b62c-23ab-4347-85a6-3d0cea18eea7</requestId>
<reservationSet/>
</DescribeInstancesResponse>
0
```
TODO:
- [ ] Update affected tests
- [ ] Update affected code
- [ ] Add new tests
- [ ] Verify it works with non EC2 AWS services (storage, etc.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Kami/libcloud aws_signing_algo_v4_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/481.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #481
----
commit 3caed8b02d97383e70dd6b9314f98506dc653493
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date: 2015-02-02T14:00:57Z
Working example of SignatureVersion 4 for AWS EC2
Signed-off-by: Tomaz Muraus <to...@apache.org>
commit b3e463f4fe3ea6c79146f41588d8194852c98e53
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date: 2015-02-02T14:03:47Z
Make supported nodes for EC2EUCentralNodeDriver available
Signed-off-by: Tomaz Muraus <to...@apache.org>
commit 65579bf0f3836767fb1c9fed3b4253d9a4e6e4dd
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date: 2015-02-02T15:02:04Z
use subclass for new version of signed connection
Signed-off-by: Tomaz Muraus <to...@apache.org>
commit bf5e60e38de2496a5b447cf30d66f6e8e5413e46
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date: 2015-03-04T14:11:59Z
Make tests pass
Signed-off-by: Tomaz Muraus <to...@apache.org>
commit 7bb56899ed76cbae162c6264eddfde3602756f0c
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date: 2015-03-05T14:08:08Z
Refactor AWS v4 signing into smaller tested functions
Signed-off-by: Tomaz Muraus <to...@apache.org>
commit 5db12e2e314eb14219ee5c08a9119f2265b506d4
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date: 2015-03-05T14:51:14Z
Small fixes
Signed-off-by: Tomaz Muraus <to...@apache.org>
commit 3af989a361f58c4cb0e3d2d4035ef6b246de335d
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date: 2015-03-05T14:51:46Z
fix linting errors
Signed-off-by: Tomaz Muraus <to...@apache.org>
commit 55652442903d50808d1ec7021e533001f63deb4c
Author: Tomaz Muraus <to...@apache.org>
Date: 2015-03-06T15:10:35Z
Fix test failure under Python 2.6.
commit 882fdf8b6652775ccd4f0987bc9ee171ba64c0d9
Author: Tomaz Muraus <to...@apache.org>
Date: 2015-03-06T16:16:38Z
Update changelog.
Closes #444
commit a84f57826fdf73c34b8ef6e98738f971dcc9a912
Author: Tomaz Muraus <to...@apache.org>
Date: 2015-03-07T15:36:32Z
Fix aws request signing so it also works with the "region" argument.
Move away from class per version approach to "signature_version" argument.
commit 35ddbe17cab6fedc03718128b13298e7b64bb1de
Author: Tomaz Muraus <to...@apache.org>
Date: 2015-03-07T15:55:05Z
Remove obsolete classes - class per region approach has been deprecated a long
time ago.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] libcloud pull request: Support for AWS signature algorithm v4 (con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/libcloud/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---