[GitHub] [skywalking] zhaoxiaojie0415 commented on issue #10438: [Bug] An error during the "sendBase" phase in the thrift plugin resulted in a duplicated traceId

["zhaoxiaojie0415 (via GitHub)" <gi...@apache.org>]

zhaoxiaojie0415 commented on issue #10438:
URL: https://github.com/apache/skywalking/issues/10438#issuecomment-1441627356

   > * https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/thrift-scenario
   
   
   
   > TBO, thrift was not mentioned once after the first adding. I don't have much to share, and as a plugin, you need to debug and find out what is happening.
   > 
   > This is what I can share
   > 
   > * This is the demo application we used for testing, https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/thrift-scenario. It is verified.
   > * These are tested versions, https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/thrift-scenario/support-version.list
   > 
   > Basically, if your codes are out of this scope, we are not tested.
   
   
   
   > TBO, thrift was not mentioned once after the first adding. I don't have much to share, and as a plugin, you need to debug and find out what is happening.
   > 
   > This is what I can share
   > 
   > * This is the demo application we used for testing, https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/thrift-scenario. It is verified.
   > * These are tested versions, https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/thrift-scenario/support-version.list
   > 
   > Basically, if your codes are out of this scope, we are not tested.
   
   <img width="1003" alt="WX20230223-193724@2x" src="https://user-images.githubusercontent.com/13363629/220895900-fc82b3bb-5583-42bd-bd3b-2de0615f783a.png">
   
   Thanks! In this test demo, after thrift compile, the method "echo" has two phase "send_echo" and "recv_echo".
   The current thrift plugin indeed create span before "send_echo", and stop span after "recv_echo", without considering error situation.
   
   I think it need also to stop span when the sendBase error, i.e. stop span in the method "handleMethodException" of "TServiceClientInterceptor".
   
   If need, I can  submit an PR later and try to solve this issue.
   By the way, this plugin can also support thrift v0.9.3， which can be added in the support-version list.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org