[GitHub] [curator] shayshim commented on a change in pull request #345: [CURATOR-551] Fix Handle Holder new connection string

[GitBox <gi...@apache.org>]

shayshim commented on a change in pull request #345: [CURATOR-551] Fix Handle Holder new connection string
URL: https://github.com/apache/curator/pull/345#discussion_r377292749
 
 

 ##########
 File path: curator-client/src/main/java/org/apache/curator/HandleHolder.java
 ##########
 @@ -70,7 +61,16 @@ String  getConnectionString()
     String getNewConnectionString()
     {
         String helperConnectionString = (helper != null) ? helper.getConnectionString() : null;
-        return ((helperConnectionString != null) && !ensembleProvider.getConnectionString().equals(helperConnectionString)) ? helperConnectionString : null;
+        String ensembleProviderConnectionString = ensembleProvider.getConnectionString();
 
 Review comment:
   I have a question. `helper` is `null` until `closeAndReset()` is called, and new connection string can be sensed only if `helper` is not `null`. Isn't it possible to have new connection string (from the `EnsembleTracker`) before `closeAndReset()` was ever called? If it is possible, then it seems like the new connection string won't be handled, since `helper` would be `null`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services