You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/29 17:36:42 UTC

[GitHub] [incubator-pekko] mdedetrich commented on pull request #363: =str Skip parsing when buffer size is 0.

mdedetrich commented on PR #363:
URL: https://github.com/apache/incubator-pekko/pull/363#issuecomment-1567375348

   tbh I am not entirely familiar with this section of Pekko, I am just being cautious/skeptical because we had a general regression here which I am trying to avoid in the future.
   
   If you are happy with adding a more detailed `JsonFraming` test that would be great, I suspect you would do this in a separate PR? If so let me know and can review this in more detail in the next couple of days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org