You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Reidddddd <gi...@git.apache.org> on 2018/10/10 02:20:41 UTC
[GitHub] zookeeper pull request #666: ZOOKEEPER-1908: setAcl should be have a recursi...
GitHub user Reidddddd opened a pull request:
https://github.com/apache/zookeeper/pull/666
ZOOKEEPER-1908: setAcl should be have a recursive function
Backport to branch-3.5.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Reidddddd/zookeeper zkp-1908
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #666
----
commit e06aab2960f3575fcdd1d30510eb9a19e69c80e2
Author: Reid Chan <re...@...>
Date: 2018-10-10T02:13:10Z
ZOOKEEPER-1908: setAcl should be have a recursive function
----
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
@Reidddddd You're probably facing with the Maven migration monster. Please check the conflicts.
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/666
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2402/
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by Reidddddd <gi...@git.apache.org>.
Github user Reidddddd commented on the issue:
https://github.com/apache/zookeeper/pull/666
I checkouted a new branch based on branch-3.5, and the PR base branch i chose is branch-3.5.
It should not have conflicts, anywhere i missed?
ping @anmolnar
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/666
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2403/
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
Committed to branch-3.5. Thanks @Reidddddd !
Please close this PR.
---
[GitHub] zookeeper pull request #666: ZOOKEEPER-1908: setAcl should be have a recursi...
Posted by Reidddddd <gi...@git.apache.org>.
Github user Reidddddd closed the pull request at:
https://github.com/apache/zookeeper/pull/666
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
Given that this is only the backport of #650 I think we're good to go.
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/666
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2404/
---
[GitHub] zookeeper issue #666: ZOOKEEPER-1908: setAcl should be have a recursive func...
Posted by Reidddddd <gi...@git.apache.org>.
Github user Reidddddd commented on the issue:
https://github.com/apache/zookeeper/pull/666
Shall we ping one more committer to give a review?
---