You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "brbzull0 (via GitHub)" <gi...@apache.org> on 2023/02/13 16:29:37 UTC
[GitHub] [trafficserver] brbzull0 opened a new pull request, #9404: DRAFT - records.yaml - Add support to load multiple YAML docs from the same file.
brbzull0 opened a new pull request, #9404:
URL: https://github.com/apache/trafficserver/pull/9404
**do not review this just yet.**
This will work as the legacy records.config where a later variable would override a previous value.
Second part is comming, this PR is missing a second part which is the hability for `traffic_ctl` to modify the `records.yaml` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9404: records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9404:
URL: https://github.com/apache/trafficserver/pull/9404#discussion_r1112165000
##########
src/traffic_ctl/CtrlCommands.cc:
##########
@@ -59,8 +64,8 @@ parse_print_opts(ts::Arguments *args)
{
return {parse_format(args)};
}
-} // namespace
-
+// } // namespace
+// using namespace print_utils;
Review Comment:
remove comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on pull request #9404: records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #9404:
URL: https://github.com/apache/trafficserver/pull/9404#issuecomment-1437413041
This will help to build tooling around records.yaml. Thanks so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 merged pull request #9404: records.yaml - Add support to load multiple YAML docs from the same file and let traffic_ctl to modify a records.yaml file
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 merged PR #9404:
URL: https://github.com/apache/trafficserver/pull/9404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org