You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/06 22:58:52 UTC
[GitHub] [druid] vogievetsky opened a new pull request #11416: Web console: Data loading walkthrough fixes
vogievetsky opened a new pull request #11416:
URL: https://github.com/apache/druid/pull/11416
Did a comprehensive review of the data loading flow in the web console and in the process found some small issues that are fixed here, 1 commit = 1 issue fixed.
The issues are:
- Quotes typo in description text
- The SQL doc structure changed (there was a column added) and the doc parsing was too lose - tightened up
- Make array input (used for column input in CSV parser) not lose your curser while typing
- Make it possible to click-to-filter the group_id column in the tasks table
- Exact table search in the Segments table was unnecessarily lowercasing the search string
- Don't resort the columns alphabetically, trust the JSON instead - maintain column order (especially helpful for formats like CSV and TSV)
- Allow bypassing the transform step, if you go to filter directly and then click `Next` it should populate the schema at that point if it has not already been done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11416:
URL: https://github.com/apache/druid/pull/11416#issuecomment-877390929
> Don't resort the columns alphabetically, trust the JSON instead - maintain column order (especially helpful for formats like CSV and TSV)
This seems like a behavior change. Is there ever a use case where the sorted column order is helpful? Should we offer users a way to fallback to the old behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11416:
URL: https://github.com/apache/druid/pull/11416#issuecomment-877650921
Thank you for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11416:
URL: https://github.com/apache/druid/pull/11416#issuecomment-877483133
Well for CSV and TSV inputs this outright fixes a UX that *looks* like a bug. I think on the "input data preview steps" (Parse data, Parse time, Transform, Filter) you want the table to look as much as the input data as it can.
I can add a button on the `Configure schema step` to let you sort the column alphabetically and that would fully cover the use case that you were previously forced into
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11416:
URL: https://github.com/apache/druid/pull/11416#discussion_r667148670
##########
File path: web-console/script/create-sql-docs.js
##########
@@ -53,17 +57,17 @@ const readDoc = async () => {
}
}
- // Make sure there are at least 10 functions for sanity
- if (functionDocs.length < 10) {
+ // Make sure there are enough functions found
+ if (functionDocs.length < EXPECTED_NUMBER_OF_FUNCTIONS) {
Review comment:
Why not an equals check instead? Should the constant be renamed to `MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #11416:
URL: https://github.com/apache/druid/pull/11416#discussion_r667233468
##########
File path: web-console/script/create-sql-docs.js
##########
@@ -53,17 +57,17 @@ const readDoc = async () => {
}
}
- // Make sure there are at least 10 functions for sanity
- if (functionDocs.length < 10) {
+ // Make sure there are enough functions found
+ if (functionDocs.length < EXPECTED_NUMBER_OF_FUNCTIONS) {
Review comment:
the constant should be renamed. I don't want someone adding a few SQL function to have to update this. If the SQL docs format change then this will still catch it because the number will drop from 130s to like 15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #11416:
URL: https://github.com/apache/druid/pull/11416#issuecomment-877510987
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #11416:
URL: https://github.com/apache/druid/pull/11416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #11416: Web console: Data loading walkthrough fixes
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11416:
URL: https://github.com/apache/druid/pull/11416#discussion_r667148670
##########
File path: web-console/script/create-sql-docs.js
##########
@@ -53,17 +57,17 @@ const readDoc = async () => {
}
}
- // Make sure there are at least 10 functions for sanity
- if (functionDocs.length < 10) {
+ // Make sure there are enough functions found
+ if (functionDocs.length < EXPECTED_NUMBER_OF_FUNCTIONS) {
Review comment:
Why not an equals check instead? Should the constant be renamed to `MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS`
Simiilar comment below for DATA_TYPES
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org