You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by "Christian Posta (JIRA)" <ji...@apache.org> on 2012/07/13 15:45:35 UTC

[jira] [Updated] (APLO-221) Documentation Incorrect regarding default credit window for a STOMP subscription

     [ https://issues.apache.org/jira/browse/APLO-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Posta updated APLO-221:
---------------------------------

    Attachment: APLO-221_Documentation_Incorrect_regarding_default_credit_window_for_a_STOMP_subscription.patch

Patch for updated docs
                
> Documentation Incorrect regarding default credit window for a STOMP subscription
> --------------------------------------------------------------------------------
>
>                 Key: APLO-221
>                 URL: https://issues.apache.org/jira/browse/APLO-221
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-website
>    Affects Versions: 1.3
>            Reporter: Christian Posta
>            Priority: Trivial
>         Attachments: APLO-221_Documentation_Incorrect_regarding_default_credit_window_for_a_STOMP_subscription.patch
>
>
> From the docs on page: http://activemq.apache.org/apollo/documentation/user-manual.html#Subscription_Flow_Control:
> "If the credit header is not specified it has the same effect as if it had been set to credit:1,65536"
> According to this code, it would default to credit:655360,655360:
> (StompProtocolHandler.on_stomp_subscribe()):
>     val credit_window = get(headers, CREDIT) match {
>       case Some(value) =>
>         value.toString.split(",").toList match {
>           case x :: Nil =>
>             InitialCreditWindow(x.toInt, buffer_size, true)
>           case x :: y :: Nil =>
>             InitialCreditWindow(x.toInt, y.toInt, true)
>           case x :: y :: z :: _ =>
>             InitialCreditWindow(x.toInt, y.toInt, z.toBoolean)
>           case _ =>
>             InitialCreditWindow(buffer_size, buffer_size, true)
>         }
>       case None =>
>         InitialCreditWindow(buffer_size, buffer_size, true)
>     }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira