You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/04/09 16:06:06 UTC
Review Request 20157: Update to use system version of boost with override
option.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1167
https://issues.apache.org/jira/browse/MESOS-1167
Repository: mesos-git
Description
-------
Updates to use system installed version of boost with optional --with-boost=<dir> override.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
3rdparty/libprocess/3rdparty/versions.am 9772753
3rdparty/libprocess/Makefile.am c785c4d
3rdparty/libprocess/configure.ac 3c515ef
LICENSE 8757c20
src/Makefile.am 95f133d
Diff: https://reviews.apache.org/r/20157/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On April 9, 2014, 3:47 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [20157]
> >
> > Failed command: git apply --index 20157.patch
> >
> > Error:
> > error: cannot apply binary patch to '3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz' without full index line
> > error: 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz: patch does not apply
> >
Umm I'm pretty sure this is a false positive.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review39894
-----------------------------------------------------------
On April 9, 2014, 2:06 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
> 3rdparty/libprocess/3rdparty/versions.am 9772753
> 3rdparty/libprocess/Makefile.am c785c4d
> 3rdparty/libprocess/configure.ac 3c515ef
> LICENSE 8757c20
> src/Makefile.am 95f133d
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review39894
-----------------------------------------------------------
Bad patch!
Reviews applied: [20157]
Failed command: git apply --index 20157.patch
Error:
error: cannot apply binary patch to '3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz' without full index line
error: 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz: patch does not apply
- Mesos ReviewBot
On April 9, 2014, 2:06 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
> 3rdparty/libprocess/3rdparty/versions.am 9772753
> 3rdparty/libprocess/Makefile.am c785c4d
> 3rdparty/libprocess/configure.ac 3c515ef
> LICENSE 8757c20
> src/Makefile.am 95f133d
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review41549
-----------------------------------------------------------
Ship it!
I added a comment above the inclusion of /opt/local/include for posterity (please verify that I was correct in my assumption for why this was necessary) and I also split the 'if WITH_BUNDLED_BOOST' thing into two pieces to keep the updates to the stout_tests and ALL_LOCAL variables in a more local scope. These were super minor, but please take a look at the resulting commit. Thanks!
- Benjamin Hindman
On April 25, 2014, 12:47 a.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 12:47 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/configure.ac 3c515ef
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/
-----------------------------------------------------------
(Updated April 25, 2014, 12:47 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
update per review.
Bugs: MESOS-1167
https://issues.apache.org/jira/browse/MESOS-1167
Repository: mesos-git
Description
-------
Updates to use system installed version of boost with optional --with-boost=<dir> override.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
3rdparty/libprocess/configure.ac 3c515ef
Diff: https://reviews.apache.org/r/20157/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/
-----------------------------------------------------------
(Updated April 11, 2014, 4:35 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated dependency as change will now depend on MESOS-1071.
Bugs: MESOS-1167
https://issues.apache.org/jira/browse/MESOS-1167
Repository: mesos-git
Description
-------
Updates to use system installed version of boost with optional --with-boost=<dir> override.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
3rdparty/libprocess/3rdparty/versions.am 9772753
3rdparty/libprocess/Makefile.am c785c4d
3rdparty/libprocess/configure.ac 3c515ef
LICENSE 8757c20
src/Makefile.am 95f133d
Diff: https://reviews.apache.org/r/20157/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On April 9, 2014, 5:40 p.m., Ben Mahler wrote:
> > Hey Tim, my understanding was that we would have the default configuration build against the bundled 3rd party libraries only.
> >
> > For those interested in building packages, we would provide the optional ability to build against system libraries only.
> >
> > From reading MESOS-1071, it doesn't look like there were any committers chiming in on the conclusions reached. Please reach out to benh and vinod to get their opinions, from a glance at this it looks to be removing boost from our bundled libraries entirely.
>
> Timothy St. Clair wrote:
> Already done ;-)
>
> For some deps such as boto and boost it's an easy win to add the checks and move on, as they exists everywhere and are a simple modification. They may however require modifications to the auto-build machines.
>
> Other deps follow the outline in MESOS-1071.
>
> Ben Mahler wrote:
> Ok, can you ask them to explicitly comment on MESOS-1071? It's not clear whether they followed up.
>
> I'm personally pretty hesitant to remove 3rd party libraries entirely as that will break things for many developers and CI machines.
>
> Benjamin Hindman wrote:
> I was not expecting to see Boost removed here. I'm not convinced this is an "easy win" because it requires people to install Boost. Moreover, it requires during configuration you to specify --with-boost= which is strictly more work (unless boost is installed in a default location).
k, I will modify back to make it piecemeal.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review39910
-----------------------------------------------------------
On April 9, 2014, 2:06 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
> 3rdparty/libprocess/3rdparty/versions.am 9772753
> 3rdparty/libprocess/Makefile.am c785c4d
> 3rdparty/libprocess/configure.ac 3c515ef
> LICENSE 8757c20
> src/Makefile.am 95f133d
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by Ben Mahler <be...@gmail.com>.
> On April 9, 2014, 5:40 p.m., Ben Mahler wrote:
> > Hey Tim, my understanding was that we would have the default configuration build against the bundled 3rd party libraries only.
> >
> > For those interested in building packages, we would provide the optional ability to build against system libraries only.
> >
> > From reading MESOS-1071, it doesn't look like there were any committers chiming in on the conclusions reached. Please reach out to benh and vinod to get their opinions, from a glance at this it looks to be removing boost from our bundled libraries entirely.
>
> Timothy St. Clair wrote:
> Already done ;-)
>
> For some deps such as boto and boost it's an easy win to add the checks and move on, as they exists everywhere and are a simple modification. They may however require modifications to the auto-build machines.
>
> Other deps follow the outline in MESOS-1071.
Ok, can you ask them to explicitly comment on MESOS-1071? It's not clear whether they followed up.
I'm personally pretty hesitant to remove 3rd party libraries entirely as that will break things for many developers and CI machines.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review39910
-----------------------------------------------------------
On April 9, 2014, 2:06 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
> 3rdparty/libprocess/3rdparty/versions.am 9772753
> 3rdparty/libprocess/Makefile.am c785c4d
> 3rdparty/libprocess/configure.ac 3c515ef
> LICENSE 8757c20
> src/Makefile.am 95f133d
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On April 9, 2014, 5:40 p.m., Ben Mahler wrote:
> > Hey Tim, my understanding was that we would have the default configuration build against the bundled 3rd party libraries only.
> >
> > For those interested in building packages, we would provide the optional ability to build against system libraries only.
> >
> > From reading MESOS-1071, it doesn't look like there were any committers chiming in on the conclusions reached. Please reach out to benh and vinod to get their opinions, from a glance at this it looks to be removing boost from our bundled libraries entirely.
Already done ;-)
For some deps such as boto and boost it's an easy win to add the checks and move on, as they exists everywhere and are a simple modification. They may however require modifications to the auto-build machines.
Other deps follow the outline in MESOS-1071.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review39910
-----------------------------------------------------------
On April 9, 2014, 2:06 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
> 3rdparty/libprocess/3rdparty/versions.am 9772753
> 3rdparty/libprocess/Makefile.am c785c4d
> 3rdparty/libprocess/configure.ac 3c515ef
> LICENSE 8757c20
> src/Makefile.am 95f133d
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On April 9, 2014, 5:40 p.m., Ben Mahler wrote:
> > Hey Tim, my understanding was that we would have the default configuration build against the bundled 3rd party libraries only.
> >
> > For those interested in building packages, we would provide the optional ability to build against system libraries only.
> >
> > From reading MESOS-1071, it doesn't look like there were any committers chiming in on the conclusions reached. Please reach out to benh and vinod to get their opinions, from a glance at this it looks to be removing boost from our bundled libraries entirely.
>
> Timothy St. Clair wrote:
> Already done ;-)
>
> For some deps such as boto and boost it's an easy win to add the checks and move on, as they exists everywhere and are a simple modification. They may however require modifications to the auto-build machines.
>
> Other deps follow the outline in MESOS-1071.
>
> Ben Mahler wrote:
> Ok, can you ask them to explicitly comment on MESOS-1071? It's not clear whether they followed up.
>
> I'm personally pretty hesitant to remove 3rd party libraries entirely as that will break things for many developers and CI machines.
I was not expecting to see Boost removed here. I'm not convinced this is an "easy win" because it requires people to install Boost. Moreover, it requires during configuration you to specify --with-boost= which is strictly more work (unless boost is installed in a default location).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review39910
-----------------------------------------------------------
On April 9, 2014, 2:06 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
> 3rdparty/libprocess/3rdparty/versions.am 9772753
> 3rdparty/libprocess/Makefile.am c785c4d
> 3rdparty/libprocess/configure.ac 3c515ef
> LICENSE 8757c20
> src/Makefile.am 95f133d
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 20157: Update to use system version of boost with
override option.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20157/#review39910
-----------------------------------------------------------
Hey Tim, my understanding was that we would have the default configuration build against the bundled 3rd party libraries only.
For those interested in building packages, we would provide the optional ability to build against system libraries only.
>From reading MESOS-1071, it doesn't look like there were any committers chiming in on the conclusions reached. Please reach out to benh and vinod to get their opinions, from a glance at this it looks to be removing boost from our bundled libraries entirely.
- Ben Mahler
On April 9, 2014, 2:06 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20157/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 2:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1167
> https://issues.apache.org/jira/browse/MESOS-1167
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updates to use system installed version of boost with optional --with-boost=<dir> override.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am eaa0db0
> 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz b867ae9
> 3rdparty/libprocess/3rdparty/versions.am 9772753
> 3rdparty/libprocess/Makefile.am c785c4d
> 3rdparty/libprocess/configure.ac 3c515ef
> LICENSE 8757c20
> src/Makefile.am 95f133d
>
> Diff: https://reviews.apache.org/r/20157/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>