You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by narendly <gi...@git.apache.org> on 2018/04/19 20:47:58 UTC

[GitHub] helix pull request #188: [HELIX-699] Compare InstanceConfigs using their IDs...

GitHub user narendly opened a pull request:

    https://github.com/apache/helix/pull/188

    [HELIX-699] Compare InstanceConfigs using their IDs in RoutingTable

    A possible race condition was causing a NPE on InstanceConfig.getHostName(). Instead of comparing hostnames and ports, we compare IDs, which are supposed to be concatenation of instance name, hostname, and port anyways and should always be set.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/narendly/helix instConfigNullCheck

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
    
----
commit 2b076c1f97dca95ef4ad817fd45d47c1ec4ff337
Author: Hunter Lee <na...@...>
Date:   2018-04-19T20:47:28Z

    [HELIX-699] Compare InstanceConfigs using their IDs in RoutingTable
    
    A possible race condition was causing a NPE on InstanceConfig.getHostName(). Instead of comparing hostnames and ports, we compare IDs, which are supposed to be concatenation of instance name, hostname, and port anyways and should always be set.

----


---

[GitHub] helix pull request #188: [HELIX-699] Compare InstanceConfigs using their IDs...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/188


---