You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2019/07/04 18:51:00 UTC
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13804
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
IMPALA-5031: Out-of-range enums are undefined behavior
This eliminates an out-of-range enum value in the end-to-end
tests. The interesting part of the backtrace is:
exec/parquet/parquet-column-readers.cc:1530:112: runtime error: load
of value 38, which is not a valid value for type 'Encoding::type'
#0 BaseScalarColumnReader::ReadDataPage()
exec/parquet/parquet-column-readers.cc:1530:112
#1 BaseScalarColumnReader::NextPage()
exec/parquet/parquet-column-readers.cc:1769:28
#2 bool ScalarColumnReader<long, (parquet::Type::type)2, true>
::ReadValueBatch<false>(int, int, unsigned char*, int*)
exec/parquet/parquet-column-readers.cc:459:12
#3 ScalarColumnReader<long, (parquet::Type::type)2, true>
::ReadNonRepeatedValueBatch(MemPool*, int, int, unsigned char*,
int*) exec/parquet/parquet-column-readers.cc:106:12
#4 HdfsParquetScanner::AssembleRows(vector<ParquetColumnReader*>
const&, RowBatch*, bool*)
exec/parquet/hdfs-parquet-scanner.cc:1113:42
#5 HdfsParquetScanner::GetNextInternal(RowBatch*)
exec/parquet/hdfs-parquet-scanner.cc:456:19
#6 HdfsParquetScanner::ProcessSplit()
exec/parquet/hdfs-parquet-scanner.cc:353:21
#7 HdfsScanNode::ProcessSplit(vector<FilterContext> const&,
MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21
#8 HdfsScanNode::ScannerThread(bool, long)
exec/hdfs-scan-node.cc:415:7
#9 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::$_0
::operator()() const exec/hdfs-scan-node.cc:337:13
Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
---
M be/src/exec/parquet/parquet-column-readers.cc
M be/src/exec/parquet/parquet-level-decoder.cc
M be/src/exec/parquet/parquet-level-decoder.h
M common/thrift/parquet.thrift
4 files changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/13804/1
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13804 )
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 09:38:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13804 )
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 03:22:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13804 )
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
IMPALA-5031: Out-of-range enums are undefined behavior
This eliminates an out-of-range enum value in the end-to-end
tests. The interesting part of the backtrace is:
exec/parquet/parquet-column-readers.cc:1530:112: runtime error: load
of value 38, which is not a valid value for type 'Encoding::type'
#0 BaseScalarColumnReader::ReadDataPage()
exec/parquet/parquet-column-readers.cc:1530:112
#1 BaseScalarColumnReader::NextPage()
exec/parquet/parquet-column-readers.cc:1769:28
#2 bool ScalarColumnReader<long, (parquet::Type::type)2, true>
::ReadValueBatch<false>(int, int, unsigned char*, int*)
exec/parquet/parquet-column-readers.cc:459:12
#3 ScalarColumnReader<long, (parquet::Type::type)2, true>
::ReadNonRepeatedValueBatch(MemPool*, int, int, unsigned char*,
int*) exec/parquet/parquet-column-readers.cc:106:12
#4 HdfsParquetScanner::AssembleRows(vector<ParquetColumnReader*>
const&, RowBatch*, bool*)
exec/parquet/hdfs-parquet-scanner.cc:1113:42
#5 HdfsParquetScanner::GetNextInternal(RowBatch*)
exec/parquet/hdfs-parquet-scanner.cc:456:19
#6 HdfsParquetScanner::ProcessSplit()
exec/parquet/hdfs-parquet-scanner.cc:353:21
#7 HdfsScanNode::ProcessSplit(vector<FilterContext> const&,
MemPool*, io::ScanRange*, long*) exec/hdfs-scan-node.cc:514:21
#8 HdfsScanNode::ScannerThread(bool, long)
exec/hdfs-scan-node.cc:415:7
#9 HdfsScanNode::ThreadTokenAvailableCb(ThreadResourcePool*)::$_0
::operator()() const exec/hdfs-scan-node.cc:337:13
Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Reviewed-on: http://gerrit.cloudera.org:8080/13804
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-column-readers.cc
M be/src/exec/parquet/parquet-level-decoder.cc
M be/src/exec/parquet/parquet-level-decoder.h
M common/thrift/parquet.thrift
4 files changed, 21 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13804 )
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 15:26:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13804 )
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3826/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jul 2019 19:30:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5031: Out-of-range enums are undefined behavior
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13804 )
Change subject: IMPALA-5031: Out-of-range enums are undefined behavior
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4603/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia86de44daaf56a941fb95b15d5dfd7b5a2752129
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 03:22:11 +0000
Gerrit-HasComments: No