You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Paulex Yang (JIRA)" <ji...@apache.org> on 2006/05/30 10:56:29 UTC

[jira] Created: (HARMONY-527) [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.

[classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.
------------------------------------------------------------------------------------------

         Key: HARMONY-527
         URL: http://issues.apache.org/jira/browse/HARMONY-527
     Project: Harmony
        Type: Bug

  Components: Classlib  
    Reporter: Paulex Yang
    Priority: Trivial


java.text.AttributedString.addAttribute() should notl add attribute when its vaule is null.  If it is fixed, the excluded org/apache/harmony/text/tests/java/text/AttributedCharacterIteratorTest.java can be enabled.

The following tests reproduces the bug,

     public void test_addAttributeLjava_text_AttributedCharacterIterator$AttributeLjava_lang_ObjectII()
    {
            AttributedString as = new AttributedString("test");
            AttributedCharacterIterator it = as.getIterator();
            as.addAttribute(AttributedCharacterIterator.Attribute.LANGUAGE, null,
                    2, 3);
            it = as.getIterator();
            assertEquals("null value limit",
                    4, it.getRunLimit(AttributedCharacterIterator.Attribute.LANGUAGE));
    }

RI 5.0 passes this test, but Harmony fails.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-527) [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-527?page=all ]
     
Mikhail Loenko closed HARMONY-527:
----------------------------------


verified by Paulex

> [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.
> ------------------------------------------------------------------------------------------
>
>          Key: HARMONY-527
>          URL: http://issues.apache.org/jira/browse/HARMONY-527
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: 01.Harmony527.diff
>
> java.text.AttributedString.addAttribute() should notl add attribute when its vaule is null.  If it is fixed, the excluded org/apache/harmony/text/tests/java/text/AttributedCharacterIteratorTest.java can be enabled.
> The following tests reproduces the bug,
>      public void test_addAttributeLjava_text_AttributedCharacterIterator$AttributeLjava_lang_ObjectII()
>     {
>             AttributedString as = new AttributedString("test");
>             AttributedCharacterIterator it = as.getIterator();
>             as.addAttribute(AttributedCharacterIterator.Attribute.LANGUAGE, null,
>                     2, 3);
>             it = as.getIterator();
>             assertEquals("null value limit",
>                     4, it.getRunLimit(AttributedCharacterIterator.Attribute.LANGUAGE));
>     }
> RI 5.0 passes this test, but Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-527) [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-527?page=all ]
     
Mikhail Loenko resolved HARMONY-527:
------------------------------------

    Resolution: Fixed

applied in revision 411104
Paulex, please verify it resolves the issue

> [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.
> ------------------------------------------------------------------------------------------
>
>          Key: HARMONY-527
>          URL: http://issues.apache.org/jira/browse/HARMONY-527
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: 01.Harmony527.diff
>
> java.text.AttributedString.addAttribute() should notl add attribute when its vaule is null.  If it is fixed, the excluded org/apache/harmony/text/tests/java/text/AttributedCharacterIteratorTest.java can be enabled.
> The following tests reproduces the bug,
>      public void test_addAttributeLjava_text_AttributedCharacterIterator$AttributeLjava_lang_ObjectII()
>     {
>             AttributedString as = new AttributedString("test");
>             AttributedCharacterIterator it = as.getIterator();
>             as.addAttribute(AttributedCharacterIterator.Attribute.LANGUAGE, null,
>                     2, 3);
>             it = as.getIterator();
>             assertEquals("null value limit",
>                     4, it.getRunLimit(AttributedCharacterIterator.Attribute.LANGUAGE));
>     }
> RI 5.0 passes this test, but Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-527) [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-527?page=all ]

Mikhail Loenko reassigned HARMONY-527:
--------------------------------------

    Assign To: Mikhail Loenko

> [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.
> ------------------------------------------------------------------------------------------
>
>          Key: HARMONY-527
>          URL: http://issues.apache.org/jira/browse/HARMONY-527
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: 01.Harmony527.diff
>
> java.text.AttributedString.addAttribute() should notl add attribute when its vaule is null.  If it is fixed, the excluded org/apache/harmony/text/tests/java/text/AttributedCharacterIteratorTest.java can be enabled.
> The following tests reproduces the bug,
>      public void test_addAttributeLjava_text_AttributedCharacterIterator$AttributeLjava_lang_ObjectII()
>     {
>             AttributedString as = new AttributedString("test");
>             AttributedCharacterIterator it = as.getIterator();
>             as.addAttribute(AttributedCharacterIterator.Attribute.LANGUAGE, null,
>                     2, 3);
>             it = as.getIterator();
>             assertEquals("null value limit",
>                     4, it.getRunLimit(AttributedCharacterIterator.Attribute.LANGUAGE));
>     }
> RI 5.0 passes this test, but Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-527) [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-527?page=all ]

Paulex Yang updated HARMONY-527:
--------------------------------

    Attachment: 01.Harmony527.diff

Please try this patch, thanks. It also enables AttributedCharacterIteratorTest by removing the exclude item in build.xml.

> [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.
> ------------------------------------------------------------------------------------------
>
>          Key: HARMONY-527
>          URL: http://issues.apache.org/jira/browse/HARMONY-527
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Priority: Trivial
>  Attachments: 01.Harmony527.diff
>
> java.text.AttributedString.addAttribute() should notl add attribute when its vaule is null.  If it is fixed, the excluded org/apache/harmony/text/tests/java/text/AttributedCharacterIteratorTest.java can be enabled.
> The following tests reproduces the bug,
>      public void test_addAttributeLjava_text_AttributedCharacterIterator$AttributeLjava_lang_ObjectII()
>     {
>             AttributedString as = new AttributedString("test");
>             AttributedCharacterIterator it = as.getIterator();
>             as.addAttribute(AttributedCharacterIterator.Attribute.LANGUAGE, null,
>                     2, 3);
>             it = as.getIterator();
>             assertEquals("null value limit",
>                     4, it.getRunLimit(AttributedCharacterIterator.Attribute.LANGUAGE));
>     }
> RI 5.0 passes this test, but Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-527) [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-527?page=comments#action_12414742 ] 

Paulex Yang commented on HARMONY-527:
-------------------------------------

looks fine, thank you, Mikhail.

> [classlib][text] java.text.AttributedString.addAttribute() incorrectly handles null value.
> ------------------------------------------------------------------------------------------
>
>          Key: HARMONY-527
>          URL: http://issues.apache.org/jira/browse/HARMONY-527
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Paulex Yang
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: 01.Harmony527.diff
>
> java.text.AttributedString.addAttribute() should notl add attribute when its vaule is null.  If it is fixed, the excluded org/apache/harmony/text/tests/java/text/AttributedCharacterIteratorTest.java can be enabled.
> The following tests reproduces the bug,
>      public void test_addAttributeLjava_text_AttributedCharacterIterator$AttributeLjava_lang_ObjectII()
>     {
>             AttributedString as = new AttributedString("test");
>             AttributedCharacterIterator it = as.getIterator();
>             as.addAttribute(AttributedCharacterIterator.Attribute.LANGUAGE, null,
>                     2, 3);
>             it = as.getIterator();
>             assertEquals("null value limit",
>                     4, it.getRunLimit(AttributedCharacterIterator.Attribute.LANGUAGE));
>     }
> RI 5.0 passes this test, but Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira