[jira] [Commented] (STREAMS-182) AbstractRegexExtensionExtractor needs to fix memory reference issue

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STREAMS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145050#comment-14145050 ] 

ASF GitHub Bot commented on STREAMS-182:
----------------------------------------

GitHub user robdouglas opened a pull request:

    https://github.com/apache/incubator-streams/pull/93

    STREAMS-182 | Fixing issue where memory reference to the hashtags set co...

    ...uld be incorrect

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robdouglas/incubator-streams STREAMS-182

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #93
    
----
commit 2443022e28fa0b98611ba8fc9f01d66645dd0099
Author: Robert Douglas <rd...@w2odigital.com>
Date:   2014-09-23T17:10:10Z

    STREAMS-182 | Fixing issue where memory reference to the hashtags set could be incorrect

----


> AbstractRegexExtensionExtractor needs to fix memory reference issue
> -------------------------------------------------------------------
>
>                 Key: STREAMS-182
>                 URL: https://issues.apache.org/jira/browse/STREAMS-182
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Robert Douglas
>
> The ensureTargetObject function in AbstractRegexExtensionExtractor does not always ensure that the collection it returns is the collection that was originally pointed to by the extensionKey.
> once the hashtags set has been created (either via Sets.newHashSet((Iterable<T>) extensions.get(extensionKey)) or Sets.newHashSet() depending on if it was already present) then it needs to be reassigned to the extensionKey. This will make sure that any modifications to the hashtags Set will be reflected in the final Activity Object



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)