You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/09 18:04:00 UTC
[jira] [Commented] (SLING-8003) Interpolate Maven variables using
the Maven Filtering APIs rather that iterate string replacing operations
[ https://issues.apache.org/jira/browse/SLING-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681773#comment-16681773 ]
ASF GitHub Bot commented on SLING-8003:
---------------------------------------
simonetripodi closed pull request #7: SLING-8003 - Interpolate Maven variables using the Maven Filtering APIs rather that iterate string replacing operations
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Interpolate Maven variables using the Maven Filtering APIs rather that iterate string replacing operations
> ----------------------------------------------------------------------------------------------------------
>
> Key: SLING-8003
> URL: https://issues.apache.org/jira/browse/SLING-8003
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model, Maven Plugins and Archetypes
> Reporter: Simone Tripodi
> Assignee: David Bosschaert
> Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.0
>
>
> Currently, the {{Substitution}} class iterates over all variables and replace them one by one in the whole input string.
> We can improve performances - and avoid writing custom variables interpolator - by replacing its use with the {{MavenReaderFilter}} API.
> It will helpful also to avoid reading the Feature file and storing it in a String, but keep working with {{Reader}} APIs.
> PR is coming
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)