You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/08 02:31:43 UTC

[GitHub] [incubator-seatunnel] kalencaya opened a new pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

kalencaya opened a new pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#issuecomment-1061350356


   Has it been tested? The same code will report NPE in my environment.
   
   Exception in thread "main" java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil
   	at org.apache.seatunnel.flink.sink.JdbcSink.outputBatch(JdbcSink.java:132)
   	at org.apache.seatunnel.flink.batch.FlinkBatchExecution.start(FlinkBatchExecution.java:77)
   	at org.apache.seatunnel.Seatunnel.entryPoint(Seatunnel.java:107)
   	at org.apache.seatunnel.Seatunnel.run(Seatunnel.java:65)
   	at org.apache.seatunnel.example.flink.LocalFlinkExample.main(LocalFlinkExample.java:32)
   Caused by: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil
   	... 5 more
   Caused by: java.lang.ClassNotFoundException: org.apache.flink.connector.jdbc.utils.JdbcTypeUtil
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
   	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
   	... 5 more


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on a change in pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
BenJFan commented on a change in pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#discussion_r821347194



##########
File path: pom.xml
##########
@@ -93,7 +93,7 @@
         <spark.binary.version>2.4</spark.binary.version>
         <neo4j.connector.spark.version>4.1.0</neo4j.connector.spark.version>
         <iceberg.version>0.13.1</iceberg.version>
-        <flink.version>1.13.6</flink.version>
+        <flink.version>1.13.5</flink.version>

Review comment:
       Why change flink version?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan edited a comment on pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
BenJFan edited a comment on pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#issuecomment-1061350356


   Has it been tested? The same code will report CNF in my environment.
   
   Exception in thread "main" java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil
   	at org.apache.seatunnel.flink.sink.JdbcSink.outputBatch(JdbcSink.java:132)
   	at org.apache.seatunnel.flink.batch.FlinkBatchExecution.start(FlinkBatchExecution.java:77)
   	at org.apache.seatunnel.Seatunnel.entryPoint(Seatunnel.java:107)
   	at org.apache.seatunnel.Seatunnel.run(Seatunnel.java:65)
   	at org.apache.seatunnel.example.flink.LocalFlinkExample.main(LocalFlinkExample.java:32)
   Caused by: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil
   	... 5 more
   Caused by: java.lang.ClassNotFoundException: org.apache.flink.connector.jdbc.utils.JdbcTypeUtil
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
   	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
   	... 5 more


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#issuecomment-1061351557


   > 
   
   
   
   > Has it been tested? The same code will report NPE in my environment.
   > 
   > Exception in thread "main" java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil at org.apache.seatunnel.flink.sink.JdbcSink.outputBatch(JdbcSink.java:132) at org.apache.seatunnel.flink.batch.FlinkBatchExecution.start(FlinkBatchExecution.java:77) at org.apache.seatunnel.Seatunnel.entryPoint(Seatunnel.java:107) at org.apache.seatunnel.Seatunnel.run(Seatunnel.java:65) at org.apache.seatunnel.example.flink.LocalFlinkExample.main(LocalFlinkExample.java:32) Caused by: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil ... 5 more Caused by: java.lang.ClassNotFoundException: org.apache.flink.connector.jdbc.utils.JdbcTypeUtil at java.net.URLClassLoader.findClass(URLClassLoader.java:387) at java.lang.ClassLoader.loadClass(ClassLoader.java:419) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) at java.lang.ClassLoader.loadClass(ClassLoader.java:352) ... 5 more
   
   maybe some jar had different version both include.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan edited a comment on pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
BenJFan edited a comment on pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#issuecomment-1061351557


   > 
   
   
   
   > Has it been tested? The same code will report CNF in my environment.
   > 
   > Exception in thread "main" java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil at org.apache.seatunnel.flink.sink.JdbcSink.outputBatch(JdbcSink.java:132) at org.apache.seatunnel.flink.batch.FlinkBatchExecution.start(FlinkBatchExecution.java:77) at org.apache.seatunnel.Seatunnel.entryPoint(Seatunnel.java:107) at org.apache.seatunnel.Seatunnel.run(Seatunnel.java:65) at org.apache.seatunnel.example.flink.LocalFlinkExample.main(LocalFlinkExample.java:32) Caused by: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil ... 5 more Caused by: java.lang.ClassNotFoundException: org.apache.flink.connector.jdbc.utils.JdbcTypeUtil at java.net.URLClassLoader.findClass(URLClassLoader.java:387) at java.lang.ClassLoader.loadClass(ClassLoader.java:419) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) at java.lang.ClassLoader.loadClass(ClassLoader.java:352) ... 5 more
   
   maybe some jar had different version both include.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kalencaya commented on pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
kalencaya commented on pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#issuecomment-1061353134


   > > 
   > 
   > > Has it been tested? The same code will report CNF in my environment.
   > > Exception in thread "main" java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil at org.apache.seatunnel.flink.sink.JdbcSink.outputBatch(JdbcSink.java:132) at org.apache.seatunnel.flink.batch.FlinkBatchExecution.start(FlinkBatchExecution.java:77) at org.apache.seatunnel.Seatunnel.entryPoint(Seatunnel.java:107) at org.apache.seatunnel.Seatunnel.run(Seatunnel.java:65) at org.apache.seatunnel.example.flink.LocalFlinkExample.main(LocalFlinkExample.java:32) Caused by: java.lang.NoClassDefFoundError: org/apache/flink/connector/jdbc/utils/JdbcTypeUtil ... 5 more Caused by: java.lang.ClassNotFoundException: org.apache.flink.connector.jdbc.utils.JdbcTypeUtil at java.net.URLClassLoader.findClass(URLClassLoader.java:387) at java.lang.ClassLoader.loadClass(ClassLoader.java:419) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) at java.lang.ClassLoader.loadClass(ClassLoader.java:352) ... 5 more
   > 
   > maybe some jar had different version both include.
   
   yeah, maybe you are right.
   I would check my local environment again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kalencaya commented on pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
kalencaya commented on pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#issuecomment-1061352595


   > 
   
   I had tested it by `mvn clean package -DskipTests -Dfast` command firstly and submit a seatunnel flink job to local standalone flink cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1432: [Feature][flink-connector-jdbc] JdbcSink plugin supports batch mode by implementing FlinkBatchSink interface

Posted by GitBox <gi...@apache.org>.
BenJFan commented on pull request #1432:
URL: https://github.com/apache/incubator-seatunnel/pull/1432#issuecomment-1062529254


   @CalvinKirs LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org