You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/11/20 08:40:43 UTC

[GitHub] [incubator-hop] hansva commented on pull request #401: Creating Constants for i18n messages

hansva commented on pull request #401:
URL: https://github.com/apache/incubator-hop/pull/401#issuecomment-731028019


   Hi @mookkiah,
   
   Thanks for the contribution! I did a counter proposal, with following changes:
   
   - Added Header to the class
   - Switched from interface to a private class as there will be no implementations for this interface and our other Constants are also in classes
   - changed name to ConstMessages to be in line with Const and ConstUi


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org