[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3365: Review use of panic in datafusion-proto crate

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3365:
URL: https://github.com/apache/arrow-datafusion/pull/3365#discussion_r966356334


##########
datafusion/proto/build.rs:
##########
@@ -32,7 +32,9 @@ fn main() -> Result<(), String> {
 fn build() -> Result<(), String> {
     use std::io::Write;
 
-    let out = std::path::PathBuf::from(std::env::var("OUT_DIR").unwrap());
+    let out = std::path::PathBuf::from(
+        std::env::var("OUT_DIR").expect("Cannot find OUT_DIR environment vairable"),

Review Comment:
   expect is a definite improvement to `unwrap` in my opinion too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org