You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/13 19:41:42 UTC

[GitHub] [lucene-solr] gerlowskija opened a new pull request #1349: Document sort param tiebreak logic

gerlowskija opened a new pull request #1349: Document sort param tiebreak logic
URL: https://github.com/apache/lucene-solr/pull/1349
 
 
   # Description
   
   I was trying to explain Solr's not-completely-deterministic `sort` param resolution to a coworker this week, and realized that this behavior wasn't documented afaict.
   
   # Solution
   
   A short ref-guide change to mention the tie-break behavior.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [x] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] uschindler commented on issue #1349: Document sort param tiebreak logic

Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #1349: Document sort param tiebreak logic
URL: https://github.com/apache/lucene-solr/pull/1349#issuecomment-599503010
 
 
   This is specially important for search-after cursors, so maybe we should mention this, too!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] gerlowskija merged pull request #1349: Document sort param tiebreak logic

Posted by GitBox <gi...@apache.org>.
gerlowskija merged pull request #1349: Document sort param tiebreak logic
URL: https://github.com/apache/lucene-solr/pull/1349
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] gerlowskija commented on issue #1349: Document sort param tiebreak logic

Posted by GitBox <gi...@apache.org>.
gerlowskija commented on issue #1349: Document sort param tiebreak logic
URL: https://github.com/apache/lucene-solr/pull/1349#issuecomment-599572742
 
 
   I can imagine how this would be an issue in that context but I haven't seen it specifically so I'm a little leery of drafting language that might not be 100% correct.
   
   If you have language you can suggest I'm happy to get it in and backported though?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org