You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by renato2099 <gi...@git.apache.org> on 2014/06/05 21:12:15 UTC
[GitHub] incubator-streams pull request: STREAMS-106
GitHub user renato2099 opened a pull request:
https://github.com/apache/incubator-streams/pull/38
STREAMS-106
https://issues.apache.org/jira/browse/STREAMS-106
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/renato2099/incubator-streams master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 18925bab54210faeed2e25bd49e9b413d52709d7
Author: renato2099 <re...@gmail.com>
Date: 2014-06-05T13:33:06Z
STREAMS-106
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-106
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/38#issuecomment-45268537
Thanks Renato. Some of these files are actually being updated by the committer as part of the initial donation of code. When he is done with that, I will apply this with the remaining files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-streams pull request: STREAMS-106
Posted by Matt Franklin <m....@gmail.com>.
It is possible to have code from compliant licenses, but that is ONLY for
when you are pulling in from another open source project. Donations that
are new code within the codebase should all be ASL 2.0
On Tue, Jun 10, 2014 at 6:03 PM, Steve Blackmon [W2O Digital] <
sblackmon@w2odigital.com> wrote:
> I'm no mentor but my understanding is that they should all have A
> compliant header, but that original authors might prefer to use a slightly
> different header, with Apache 2 license but different copyright details.
>
> Steve Blackmon
>
> > On Jun 10, 2014, at 4:48 PM, Renato Marroquín Mogrovejo <
> renatoj.marroquin@gmail.com> wrote:
> >
> > Hi Steve,
> >
> > Cool news! But just a quick question here, mustn't all files inside an
> > Apache project have an Apache license header? I mean they already
> submitted
> > their code to Apache Streams right? [1]
> > BTW I am in no hurry to get this in ;) but just trying to understand
> better
> > how we are supposed to deal with sort of situations.
> >
> >
> > Renato M.
> >
> > [1]
> http://cp.mcafee.com/d/k-Kr3xASyNtdxBMQsFzztPqqb8VUttdUsrjhp7f3zhPssYrjhp7f3HFLf6QQm66jhOYYCCrEgfSNlmI0kojGhzlJrBPpxeF6dmRKnd-Owe76zBB_HYOesuujWZOW8V4tMV4syyZORQr8EGEEIYG7DR8OJMddECQPt-jLuZXTLuVKVI05GSS9_M073_8WvB8SbA_R3UQU76QfcBU_dKc2WabUULgwvJyGJo764WAoRrmVs5kD7ZlFQEmr8reIuRrr4_U02rvjKCr1vF6y0QJxakMKSgdbFEwB2Pp3pRynFefWHgQgbdDDCy2fyPvQCAq81w4wIq41IobETsdLK6TO9I
> >
> >
> > 2014-06-10 21:37 GMT+02:00 Steve Blackmon <st...@blackmon.org>:
> >
> >> I’ve merged license headers on all modules that I initially committed
> into
> >> master. There are additional modules by other authors impacted by this
> >> pull request. I’ll give everyone a few days to check out the PR and
> let us
> >> know if you want any of the files you committed to have a header
> different
> >> from the header being added in the PR. Otherwise I’ll apply the patch
> to
> >> the rest of the files, which should bring all of the files in the
> project
> >> to a good place and complete this story. At that point I think we
> should
> >> enable rat so the list can get notified if new classes get added that
> are
> >> missing license headers.
> >>
> >> Thanks for helping us out with this Renato!
> >>
> >> Steve Blackmon
> >> sblackmon@apache.org
> >>
> >>> On Jun 5, 2014, at 3:26 PM, renato2099 <gi...@git.apache.org> wrote:
> >>>
> >>> Github user renato2099 commented on the pull request:
> >>
> http://cp.mcafee.com/d/FZsS73gArhoKCMOUqekNNKVJd5AsYeKCYedFEIzDxNEVKeudFEIzDxRQTDzqqb339EVuujjdQ87XoGHm0ac9R8NGSJOVIMDkz6HqTbC_pg73zhOO_R-p7eff9ZuVt4syeUsyehhuVqWdAklkkmul3PWApmU6CQPqpK_9TLuZXTLsTsSjDdqymohBcCSgVvdmSNfYB2Pp3pRynFefWHj5CPPYpu0Olad-KHY9BS7QT3hOYy-rgYOnzYSUMbEELzyZ21-SaGRwsojGhzlJrBMlisvRmDixpIxIWNXlJIj_w09JZeWpI5-Aq83iS4Fj2Xp0QKCy2kbdAdDm9uAU_GJ3h0ISuuq88-bd_iqhEw60i2NEg6NwKztMS-UrZCBt1CBl5Os
> >>>
> >>> Cool Matt! I will find another task to tackle.
> >>>
> >>>
> >>> ---
> >>> If your project is set up for it, you can reply to this email and have
> >> your
> >>> reply appear on GitHub as well. If your project does not have this
> >> feature
> >>> enabled and wishes so, or if the feature is enabled but not working,
> >> please
> >>> contact infrastructure at infrastructure@apache.org or file a JIRA
> >> ticket
> >>> with INFRA.
> >>> ---
> >>
> >>
>
Re: [GitHub] incubator-streams pull request: STREAMS-106
Posted by "Steve Blackmon [W2O Digital]" <sb...@w2odigital.com>.
I'm no mentor but my understanding is that they should all have A compliant header, but that original authors might prefer to use a slightly different header, with Apache 2 license but different copyright details.
Steve Blackmon
> On Jun 10, 2014, at 4:48 PM, Renato Marroquín Mogrovejo <re...@gmail.com> wrote:
>
> Hi Steve,
>
> Cool news! But just a quick question here, mustn't all files inside an
> Apache project have an Apache license header? I mean they already submitted
> their code to Apache Streams right? [1]
> BTW I am in no hurry to get this in ;) but just trying to understand better
> how we are supposed to deal with sort of situations.
>
>
> Renato M.
>
> [1] http://cp.mcafee.com/d/k-Kr3xASyNtdxBMQsFzztPqqb8VUttdUsrjhp7f3zhPssYrjhp7f3HFLf6QQm66jhOYYCCrEgfSNlmI0kojGhzlJrBPpxeF6dmRKnd-Owe76zBB_HYOesuujWZOW8V4tMV4syyZORQr8EGEEIYG7DR8OJMddECQPt-jLuZXTLuVKVI05GSS9_M073_8WvB8SbA_R3UQU76QfcBU_dKc2WabUULgwvJyGJo764WAoRrmVs5kD7ZlFQEmr8reIuRrr4_U02rvjKCr1vF6y0QJxakMKSgdbFEwB2Pp3pRynFefWHgQgbdDDCy2fyPvQCAq81w4wIq41IobETsdLK6TO9I
>
>
> 2014-06-10 21:37 GMT+02:00 Steve Blackmon <st...@blackmon.org>:
>
>> I’ve merged license headers on all modules that I initially committed into
>> master. There are additional modules by other authors impacted by this
>> pull request. I’ll give everyone a few days to check out the PR and let us
>> know if you want any of the files you committed to have a header different
>> from the header being added in the PR. Otherwise I’ll apply the patch to
>> the rest of the files, which should bring all of the files in the project
>> to a good place and complete this story. At that point I think we should
>> enable rat so the list can get notified if new classes get added that are
>> missing license headers.
>>
>> Thanks for helping us out with this Renato!
>>
>> Steve Blackmon
>> sblackmon@apache.org
>>
>>> On Jun 5, 2014, at 3:26 PM, renato2099 <gi...@git.apache.org> wrote:
>>>
>>> Github user renato2099 commented on the pull request:
>> http://cp.mcafee.com/d/FZsS73gArhoKCMOUqekNNKVJd5AsYeKCYedFEIzDxNEVKeudFEIzDxRQTDzqqb339EVuujjdQ87XoGHm0ac9R8NGSJOVIMDkz6HqTbC_pg73zhOO_R-p7eff9ZuVt4syeUsyehhuVqWdAklkkmul3PWApmU6CQPqpK_9TLuZXTLsTsSjDdqymohBcCSgVvdmSNfYB2Pp3pRynFefWHj5CPPYpu0Olad-KHY9BS7QT3hOYy-rgYOnzYSUMbEELzyZ21-SaGRwsojGhzlJrBMlisvRmDixpIxIWNXlJIj_w09JZeWpI5-Aq83iS4Fj2Xp0QKCy2kbdAdDm9uAU_GJ3h0ISuuq88-bd_iqhEw60i2NEg6NwKztMS-UrZCBt1CBl5Os
>>>
>>> Cool Matt! I will find another task to tackle.
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and have
>> your
>>> reply appear on GitHub as well. If your project does not have this
>> feature
>>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>> ticket
>>> with INFRA.
>>> ---
>>
>>
Re: [GitHub] incubator-streams pull request: STREAMS-106
Posted by Renato Marroquín Mogrovejo <re...@gmail.com>.
Hi Steve,
Cool news! But just a quick question here, mustn't all files inside an
Apache project have an Apache license header? I mean they already submitted
their code to Apache Streams right? [1]
BTW I am in no hurry to get this in ;) but just trying to understand better
how we are supposed to deal with sort of situations.
Renato M.
[1] http://www.apache.org/legal/src-headers.html
2014-06-10 21:37 GMT+02:00 Steve Blackmon <st...@blackmon.org>:
> I’ve merged license headers on all modules that I initially committed into
> master. There are additional modules by other authors impacted by this
> pull request. I’ll give everyone a few days to check out the PR and let us
> know if you want any of the files you committed to have a header different
> from the header being added in the PR. Otherwise I’ll apply the patch to
> the rest of the files, which should bring all of the files in the project
> to a good place and complete this story. At that point I think we should
> enable rat so the list can get notified if new classes get added that are
> missing license headers.
>
> Thanks for helping us out with this Renato!
>
> Steve Blackmon
> sblackmon@apache.org
>
> On Jun 5, 2014, at 3:26 PM, renato2099 <gi...@git.apache.org> wrote:
>
> > Github user renato2099 commented on the pull request:
> >
> >
> https://github.com/apache/incubator-streams/pull/38#issuecomment-45269815
> >
> > Cool Matt! I will find another task to tackle.
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>
Re: [GitHub] incubator-streams pull request: STREAMS-106
Posted by Steve Blackmon <st...@blackmon.org>.
I’ve merged license headers on all modules that I initially committed into master. There are additional modules by other authors impacted by this pull request. I’ll give everyone a few days to check out the PR and let us know if you want any of the files you committed to have a header different from the header being added in the PR. Otherwise I’ll apply the patch to the rest of the files, which should bring all of the files in the project to a good place and complete this story. At that point I think we should enable rat so the list can get notified if new classes get added that are missing license headers.
Thanks for helping us out with this Renato!
Steve Blackmon
sblackmon@apache.org
On Jun 5, 2014, at 3:26 PM, renato2099 <gi...@git.apache.org> wrote:
> Github user renato2099 commented on the pull request:
>
> https://github.com/apache/incubator-streams/pull/38#issuecomment-45269815
>
> Cool Matt! I will find another task to tackle.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-streams pull request: STREAMS-106
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/incubator-streams/pull/38#issuecomment-45269815
Cool Matt! I will find another task to tackle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-106
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/incubator-streams/pull/38#issuecomment-51983730
Finally I got this updated guys! Could you please check it and then we could close this?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-106
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on the pull request:
https://github.com/apache/incubator-streams/pull/38#issuecomment-46043484
@mfranklin i updated headers on the modules i donated. just a handful left which this patch should cover
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-106
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/38#issuecomment-46254975
@renato2099 can you merge incubator-streams/master into this branch and push to your remote branch? will make applying this PR easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-106
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-106
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/38#issuecomment-51990302
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---